Skip to content

chore(components, styles): use px instead of rem for header styles #8336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alizedebray wants to merge 6 commits into from
Open

chore(components, styles): use px instead of rem for header styles #8336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
528bdb5
chose(docs): fix containers
alizedebray Aug 18, 2026
d605704
Update tabs.stories.ts
alizedebray Aug 18, 2026
608739d
Update tabs.stories.ts
alizedebray Aug 18, 2026
059d645
chore(components, styles): use px instead of rem for header styles
alizedebray Aug 19, 2026
993e061
Reset rem font-sizes
alizedebray Aug 20, 2026
6dcbccd
revert unnecessary changes
alizedebray Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/components/src/components/post-footer/post-footer.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ footer {
.footer-copyright {
display: flex;
flex-wrap: wrap;
column-gap: 0.5rem;
column-gap: 8px;
font-size: var(--post-footer-copyright-font-size);
}

Expand Down
48 changes: 24 additions & 24 deletions packages/components/src/components/post-header/custom-properties.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,40 +20,40 @@
);

@include media.only(desktop) {
--post-header-gap: 0.5rem;
--post-global-header-padding-inline-start: 0.25rem;
--post-global-header-padding-inline-end: 0.5rem;
--post-local-header-padding-inline-start: 0.75rem;
--post-local-header-padding-inline-end: 0.5rem;
--post-header-gap: 8px;
--post-global-header-padding-inline-start: 4px;
--post-global-header-padding-inline-end: 8px;
--post-local-header-padding-inline-start: 12px;
--post-local-header-padding-inline-end: 8px;
}

@include media.only(tablet) {
--post-header-gap: 0.75rem 0.5rem;
--post-global-header-padding-inline-start: 0.25rem;
--post-global-header-padding-inline-end: 0.25rem;
--post-local-header-padding-inline-start: 0.75rem;
--post-local-header-padding-inline-end: 0.25rem;
--post-local-header-padding-block: 0.75rem;
--post-burger-menu-padding-inline: 2.5rem;
--post-burger-menu-body-gap: 2rem;
--post-burger-menu-footer-gap: 1.5rem;
--post-header-gap: 12px 8px;
--post-global-header-padding-inline-start: 4px;
--post-global-header-padding-inline-end: 4px;
--post-local-header-padding-inline-start: 12px;
--post-local-header-padding-inline-end: 4px;
--post-local-header-padding-block: 12px;
--post-burger-menu-padding-inline: 40px;
--post-burger-menu-body-gap: 32px;
--post-burger-menu-footer-gap: 24px;
}

// this is being discussed in Figma
@include media.only(sm) {
--post-burger-menu-padding-inline: 1rem;
--post-burger-menu-padding-inline: 16px;
}

@include media.only(mobile) {
--post-header-gap: 0.75rem 0.5rem;
--post-global-header-padding-inline-start: 0rem;
--post-global-header-padding-inline-end: 0.5rem;
--post-local-header-padding-inline-start: 0.5rem;
--post-local-header-padding-inline-end: 0.5rem;
--post-local-header-padding-block: 0.5rem;
--post-burger-menu-padding-inline: 1rem;
--post-burger-menu-body-gap: 1.5rem;
--post-burger-menu-footer-gap: 1rem;
--post-header-gap: 12px 8px;
--post-global-header-padding-inline-start: 0px;
--post-global-header-padding-inline-end: 8px;
--post-local-header-padding-inline-start: 8px;
--post-local-header-padding-inline-end: 8px;
--post-local-header-padding-block: 8px;
--post-burger-menu-padding-inline: 16px;
--post-burger-menu-body-gap: 24px;
--post-burger-menu-footer-gap: 16px;
}
}

Expand Down
12 changes: 6 additions & 6 deletions packages/components/src/components/post-header/post-header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ header,
height: var(--post-logo-height);
min-height: var(--post-global-header-reduced-height);
max-height: 100%;
margin-inline-end: calc(1.25rem - var(--post-header-gap));
margin-inline-end: calc(20px - var(--post-header-gap));

// Offset the logo to ensure visual alignment with the local header content
margin-inline-start: clamp(
Expand Down Expand Up @@ -161,7 +161,7 @@ header,

@include media-mx.only(mobile) {
@include header-mx.nav-item-icon-only;
padding: 0.625rem;
padding: 10px;
}

@include media-mx.only(desktop) {
Expand Down Expand Up @@ -204,21 +204,21 @@ header,

.burger-menu-body {
flex-grow: 1;
padding-block: 1.5rem;
padding-block: 24px;
gap: var(--post-burger-menu-body-gap);
}

.burger-menu-footer {
background-color: #f0efed;
padding-block: 1rem 1.5rem;
padding-block: 16px 24px;
gap: var(--post-burger-menu-footer-gap);
}

.local-nav {
min-height: 3.5rem;
min-height: 56px;
display: flex;
align-items: center;
justify-content: flex-end;
padding-inline: 0.25rem;
padding-inline: 4px;
}
}
4 changes: 2 additions & 2 deletions packages/components/src/components/post-language-menu/post-language-menu.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,6 @@ tokens.$default-map: components.$post-button;

.post-language-menu-list {
display: flex;
gap: 0.5rem;
margin-top: 1rem;
gap: 8px;
margin-top: 16px;
}
4 changes: 2 additions & 2 deletions packages/components/src/components/post-mainnavigation/post-mainnavigation.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ nav {
}

.scroll-control {
$icon-size: 1rem;
$button-padding: 1rem;
$icon-size: 16px;
$button-padding: 16px;
$button-width: $icon-size + 2 * $button-padding;

z-index: 1;
Expand Down
18 changes: 9 additions & 9 deletions packages/components/src/components/post-megadropdown/post-megadropdown.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
box-shadow: elevation.$elevation-300;

@include media.only(desktop) {
max-height: calc(100vh - var(--post-header-height) - 3rem);
max-height: calc(100vh - var(--post-header-height) - 48px);
background-color: #f0efed;
z-index: -1;
inset-block-start: 100%;
Expand Down Expand Up @@ -49,7 +49,7 @@
position: relative;

@include media.only(desktop) {
padding: 3rem 2.5rem 2.5rem;
padding: 48px 40px 40px;
}

@include media.max(desktop) {
Expand All @@ -59,18 +59,18 @@
min(var(--post-header-scroll-parent-height, 100dvh), 100dvh) - var(--post-header-height)
);
padding-inline: var(--post-burger-menu-padding-inline);
padding-block-start: 1.5rem;
padding-block-start: 24px;
}

.megadropdown-content {
@include media.max(desktop) {
padding-block-end: 1.5rem;
padding-block-end: 24px;
}
}
}

.megadropdown-title {
margin-block: 0 1rem;
margin-block: 0 16px;
font-weight: 950;

@include media.only(tablet) {
Expand All @@ -95,18 +95,18 @@
}

@include media.only(tablet) {
margin-block-end: 2rem;
margin-block-end: 32px;
}

@include media.only(mobile) {
margin-block-end: 1.5rem;
margin-block-end: 24px;
}
}

.close-button {
position: absolute;
inset-block-start: 0.5rem;
inset-inline-end: 0.5rem;
inset-block-start: 8px;
inset-inline-end: 8px;

@include media.max(lg) {
display: none;
Expand Down
22 changes: 11 additions & 11 deletions packages/components/src/components/post-menu-item/post-menu-item.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,33 +18,33 @@ post-menu-item {
position: relative;
display: flex;
align-items: center;
padding: 0.5rem 0.75rem 0.5rem 1rem;
gap: 0.75rem;
padding: 8px 12px 8px 16px;
gap: 12px;
font-size: 0.875rem;
color: #050400;
border-radius: 0;

post-icon {
width: 1rem;
height: 1rem;
margin-block: 0.25rem;
width: 16px;
height: 16px;
margin-block: 4px;
}

@include media.min(md) {
font-size: 1rem;
padding-block: 0.75rem;
gap: 1rem;
padding-block: 12px;
gap: 16px;

post-icon {
width: 1.5rem;
height: 1.5rem;
width: 24px;
height: 24px;
margin: 0;
}
}

@include media.min(lg) {
font-size: 1.25rem;
padding-block: 0.8125rem;
padding-block: 13px;
}

&:focus-visible {
Expand All @@ -57,4 +57,4 @@ post-menu-item {
color: #fff;
}
}
}
}
12 changes: 6 additions & 6 deletions packages/components/src/components/post-menu/post-menu.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,24 +8,24 @@
:where([part='post-menu']) {
display: flex;
flex-direction: column;
padding-block: 0.5rem;
padding-block: 8px;
}

::slotted([slot='header']) {
margin-top: -0.5rem;
padding: 1rem;
margin-top: -8px;
padding: 16px;
display: flex;
align-items: center;
gap: 0.5rem;
gap: 8px;
border-block-end: 1px solid #050400;
font-weight: 700;

@include media.max(lg) {
padding: 0.75rem 1rem;
padding: 12px 16px;
}

@include media.max(md) {
padding: 0.5rem 1rem;
padding: 8px 16px;
}
}

Expand Down
4 changes: 2 additions & 2 deletions packages/components/src/components/post-popover/post-popover.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,13 @@
background-color: var(--post-current-bg);
display: flex;
align-items: self-start;
padding: 0.5em;
padding: 8px;

min-width: 160px;
max-width: var(--post-popover-max-width, 280px);
}

.popover-content {
padding: 0.5em;
padding: 8px;
flex-grow: 1;
}
Loading
Loading