Skip to content

chore(components, styles): use px instead of rem for header styles - #8336

Open
alizedebray wants to merge 6 commits into
7700-close-link-in-the-headerfrom
use-px-intead-of-rem-for-header-styles
Open

chore(components, styles): use px instead of rem for header styles#8336
alizedebray wants to merge 6 commits into
7700-close-link-in-the-headerfrom
use-px-intead-of-rem-for-header-styles

Conversation

@alizedebray

@alizedebray alizedebray commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

📄 Description

This PR replaces all rem values by px values in the header so it is easier to align with Figma.


🔮 Design review

  • Design review done
  • No design review needed

🧪 Visual regression tests

  • Visual changes detected and approved (Check this box if VRT fails and changes are intentional)

📝 Checklist

  • ✅ My code follows the style guidelines of this project
  • 🛠️ I have performed a self-review of my own code
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings or errors
  • 🧪 I have added tests that prove my fix is effective or that my feature works
  • ✔️ New and existing unit tests pass locally with my changes

@alizedebray
alizedebray requested review from a team as code owners August 19, 2026 08:02
@alizedebray
alizedebray requested review from alionazherdetska and removed request for a team August 19, 2026 08:02
@changeset-bot

changeset-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 6dcbccd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@swisspost-bot

swisspost-bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Related Previews

@alionazherdetska alionazherdetska left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert changes to apps/documentation/src/stories/components/tabs/tabs.stories.ts.

@alizedebray
alizedebray force-pushed the use-px-intead-of-rem-for-header-styles branch from e97ae9d to 6dcbccd Compare August 21, 2026 12:39
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants