build: re-run PR title check on synchronize without cancelling - #227
Merged
tokoko merged 1 commit intoJul 20, 2026
Merged
Conversation
The "PR title / description conforms to semantic-release" check is a required status check, and GitHub keys required checks to the head commit. After substrait-io#203 dropped `synchronize` from the triggers, pushing a new commit to a PR no longer re-reported the check on the new head commit, leaving it stranded on the previous commit and blocking the PR indefinitely (e.g. substrait-io#224). Re-add `synchronize` so the check reports on every head commit, and set `cancel-in-progress: false` to avoid reintroducing the double check-run race from substrait-io#198: a Dependabot rebase fires `synchronize` and `edited` on the same commit at once, and cancelling one leaves a cancelled check-run on the head commit that fails the status rollup. With cancellation disabled the second event queues behind the first and both finish as successes. 🤖 Generated with AI
tokoko
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The PR title / description conforms to semantic-release check — a required status check on
main— stops being reported once a PR receives a new commit, leaving the PR permanentlyBLOCKED(e.g. #224). The check runs and passes when the PR is opened, but pushing a follow-up commit never re-reports it.Root cause
GitHub keys required status checks to the head commit of the PR. #203 dropped
synchronizefrom the workflow triggers (to fix the double check-run race in #198), so a push no longer runs the check. The passing check-run stays attached to the previous head commit, and the new head commit has noPR title / description conforms to semantic-releaserun at all — so the status rollup can never be satisfied.Dropping
synchronizeis fundamentally incompatible with this being a required check: any contributor who pushes after opening a PR strands the required check.Fix
synchronizeso the check reports on every head commit.cancel-in-progress: falseso the chore(deps): bump actions/checkout from 6 to 7 #198 race doesn't return. That race left a cancelled check-run becausesynchronizeandedited(fired together by a Dependabot rebase on the same commit) landed in the same concurrency group and one cancelled the other. With cancellation disabled the second event queues behind the first and both finish as successes — two harmlessSUCCESScheck-runs instead of oneSUCCESS+ oneCANCELLED. The concurrency group is kept so runs for a PR still serialize and the comment job can't race with itself.🤖 Generated with AI