Commit 3a10afb
authored
build: re-run PR title check on synchronize without cancelling (#227)
## Problem
The **PR title / description conforms to semantic-release** check — a
required status check on `main` — stops being reported once a PR
receives a new commit, leaving the PR permanently `BLOCKED` (e.g. #224).
The check runs and passes when the PR is opened, but pushing a follow-up
commit never re-reports it.
## Root cause
GitHub keys required status checks to the **head commit** of the PR.
#203 dropped `synchronize` from the workflow triggers (to fix the double
check-run race in #198), so a push no longer runs the check. The passing
check-run stays attached to the *previous* head commit, and the new head
commit has no `PR title / description conforms to semantic-release` run
at all — so the status rollup can never be satisfied.
Dropping `synchronize` is fundamentally incompatible with this being a
required check: any contributor who pushes after opening a PR strands
the required check.
## Fix
- Re-add `synchronize` so the check reports on every head commit.
- Set `cancel-in-progress: false` so the #198 race doesn't return. That
race left a *cancelled* check-run because `synchronize` and `edited`
(fired together by a Dependabot rebase on the same commit) landed in the
same concurrency group and one cancelled the other. With cancellation
disabled the second event queues behind the first and both finish as
successes — two harmless `SUCCESS` check-runs instead of one `SUCCESS` +
one `CANCELLED`. The concurrency group is kept so runs for a PR still
serialize and the comment job can't race with itself.
🤖 Generated with AI1 parent 4d183f5 commit 3a10afb
1 file changed
Lines changed: 12 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
10 | 9 | | |
11 | | - | |
| 10 | + | |
12 | 11 | | |
13 | | - | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
14 | 17 | | |
15 | 18 | | |
16 | | - | |
| 19 | + | |
17 | 20 | | |
18 | 21 | | |
19 | 22 | | |
| |||
0 commit comments