Skip to content

SF-3426 Auto focus note dialog input when it opens #4059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nateowami merged 1 commit into from
Aug 19, 2026
Merged

SF-3426 Auto focus note dialog input when it opens #4059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...Forge.Scripture/ClientApp/src/app/translate/editor/note-dialog/note-dialog.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ <h1 mat-dialog-title class="dialog-icon-title">
<form [formGroup]="noteDialogForm">
<mat-form-field class="full-width" appearance="outline">
<mat-label>{{ t("your_comment") }}</mat-label>
<textarea matInput formControlName="comment"></textarea>
<textarea matInput formControlName="comment" cdkFocusInitial></textarea>
<mat-error>{{ t("required") }}</mat-error>
</mat-form-field>
</form>
Expand Down
6 changes: 6 additions & 0 deletions ...ge.Scripture/ClientApp/src/app/translate/editor/note-dialog/note-dialog.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,12 @@ describe('NoteDialogComponent', () => {
expect(env.flagIcon).toEqual('/assets/icons/TagIcons/' + SF_TAG_ICON + '.png');
}));

it('focuses the comment textarea when the thread already has notes', fakeAsync(() => {
env = new TestEnvironment({ noteThread: TestEnvironment.getNoteThread() });
expect(env.notes.length).toBeGreaterThan(0);
expect(document.activeElement).toBe(env.noteInputElement.nativeElement);
}));

it('does not save note if textarea is empty', fakeAsync(() => {
env = new TestEnvironment({ verseRef: new VerseRef('MAT 1:1') });
expect(env.noteInputElement).toBeTruthy();
Expand Down
Loading