SF-3426 Auto focus note dialog input when it opens - #4059
Merged
Conversation
Nateowami
marked this pull request as draft
August 19, 2026 02:47
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4059 +/- ##
=======================================
Coverage 81.10% 81.10%
=======================================
Files 661 661
Lines 43060 43060
Branches 7033 7059 +26
=======================================
Hits 34925 34925
Misses 6977 6977
Partials 1158 1158 ☔ View full report in Codecov by Harness. |
Nateowami
added
testing complete
Nateowami
marked this pull request as ready for review
August 19, 2026 14:14
RaymondLuong3
approved these changes
Aug 19, 2026
RaymondLuong3
left a comment
RaymondLuong3
left a comment
Collaborator
There was a problem hiding this comment.
@RaymondLuong3 reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Nateowami).
RaymondLuong3
force-pushed
the
fix/SF-3426-note-dialog-auto-focus
branch
from
August 19, 2026 15:54
a52d5ab to
3065db7
Compare
Nateowami
enabled auto-merge (squash)
August 19, 2026 15:55
Nateowami
force-pushed
the
fix/SF-3426-note-dialog-auto-focus
branch
from
August 19, 2026 17:41
3065db7 to
c64bcab
Compare
This additionally steals focus from the editor
Nateowami
force-pushed
the
fix/SF-3426-note-dialog-auto-focus
branch
from
August 19, 2026 17:43
c64bcab to
417ccf7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This additionally steals focus from the editor, and I'm hoping that fixes the issues where the user can accidentally edit behind the dialog (but this change can also stand without that).
This change is