ROSAENG-61179 | test: add ocm wrapper request-contract coverage

[olucasfreitas]

PR Summary

Splits the CRUD-style pkg/ocm request-contract coverage into its own stacked PR for easier review.

Detailed Description of the Issue

This PR is the CRUD/request-shape layer of the ROSAENG-61179 stack. It groups the DNS domain, ingress, node pool, OIDC config, and user client tests that primarily validate endpoint contracts, payloads, and wrapper behavior, while depending on the shared test harness from the base PR.

Related Issues and PRs

• Jira: ROSAENG-61179
• Fixes: N/A
• Related PR(s):
  • Base PR: #3442
  • Sibling PR: #3443 — add-on availability coverage
  • Sibling PR: #3444 — lifecycle and version coverage
  • Holding PR: #3437
• Related design/docs: N/A

Type of Change

• fix - resolves an incorrect behavior or bug.
• docs - updates documentation only.
• style - formatting or naming changes with no logic impact.
• refactor - code restructuring with no behavior change.
• test - adds or updates tests only.
• chore - maintenance work (tooling, housekeeping, non-product code).
• build - changes build system, packaging, or dependencies for build output.
• ci - changes CI pipelines, jobs, or automation workflows.
• perf - improves performance without changing intended behavior.

Previous Behavior

• The CRUD-style OCM client coverage for DNS domains, ingresses, node pools, OIDC configs, and users was bundled into the large holding branch instead of a smaller review slice.

Behavior After This Change

• The CRUD/request-contract tests for these pkg/ocm wrappers are isolated in one PR, with focused request assertions and no unrelated lifecycle or add-on changes in the same diff.

How to Test (Step-by-Step)

Preconditions

• Run from the repo root.
• Use a Go 1.26.3 compatible toolchain. If the local default toolchain is older, prefix commands with GOTOOLCHAIN=auto.

Test Steps

1. Run GOTOOLCHAIN=auto go test ./pkg/ocm -count=1 -ginkgo.focus="DNS Domains|Ingresses|NodePools|Oidc Config|Users".

Expected Results

• The CRUD/request-contract pkg/ocm specs pass on top of the base branch.

Proof of the Fix

• Screenshots: N/A
• Videos: N/A
• Logs/CLI output:
  • GOTOOLCHAIN=auto go test ./pkg/ocm -count=1 -ginkgo.focus="DNS Domains|Ingresses|NodePools|Oidc Config|Users"
• Other artifacts: N/A

Breaking Changes

• No breaking changes
• Yes, this PR introduces a breaking change (describe impact and migration plan below)

Breaking Change Details / Migration Plan

N/A

Developer Verification Checklist

• Commit subject/title follows [JIRA-TICKET] | [TYPE]: <MESSAGE>.
• PR description clearly explains both what changed and why.
• Relevant Jira/GitHub issues and related PRs are linked.
• make install-hooks has been run in this clone.
• Tests were added/updated where appropriate.
• I manually tested the change.
• make test passes.
• make lint passes.
• make rosa passes.
• Documentation or repo-local agent guidance was added/updated where appropriate.
• Any risk, limitation, or follow-up work is documented.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 0e3a8736-974c-4624-9602-54b2b282c5a8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olucasfreitas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [olucasfreitas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment