ROSAENG-61179 | fix: preserve add-on availability semantics

[olucasfreitas]

PR Summary

Isolates the pkg/ocm add-on availability bug fixes and the focused add-on coverage from the broader ROSAENG-61179 work.

Detailed Description of the Issue

This PR is the add-on-focused layer of the ROSAENG-61179 stack. It keeps the zero-cost add-on availability and AZ handling changes together with the add-on-specific request-contract and edge-path tests, while depending on the shared test harness from the base PR.

Related Issues and PRs

• Jira: ROSAENG-61179
• Fixes: N/A
• Related PR(s):
  • Base PR: #3442
  • Sibling PR: #3445 — CRUD request-contract coverage
  • Sibling PR: #3444 — lifecycle and version coverage
  • Holding PR: #3437
• Related design/docs: N/A

Type of Change

• fix - resolves an incorrect behavior or bug.
• docs - updates documentation only.
• style - formatting or naming changes with no logic impact.
• refactor - code restructuring with no behavior change.
• test - adds or updates tests only.
• chore - maintenance work (tooling, housekeeping, non-product code).
• build - changes build system, packaging, or dependencies for build output.
• ci - changes CI pipelines, jobs, or automation workflows.
• perf - improves performance without changing intended behavior.

Previous Behavior

• Zero-cost add-ons without quota metadata could be reported as unavailable or disappear from cluster add-on results.
• Add-on request-contract coverage lived in the larger all-in-one branch instead of a dedicated review slice.

Behavior After This Change

• Zero-cost add-ons remain available and cluster-visible even when quota metadata is absent, defaulting to AZType = ANY until quota metadata overrides that default.
• Add-on-specific request, error, and compatibility coverage is reviewable on its own.

How to Test (Step-by-Step)

Preconditions

• Run from the repo root.
• Use a Go 1.26.3 compatible toolchain. If the local default toolchain is older, prefix commands with GOTOOLCHAIN=auto.

Test Steps

1. Run GOTOOLCHAIN=auto go test ./pkg/ocm -count=1 -args -ginkgo.focus="Addons API client behavior".
2. Run GOTOOLCHAIN=auto make rosa.

Expected Results

• The add-on-focused pkg/ocm specs pass.
• The CLI still builds successfully on this stacked branch.

Proof of the Fix

• Screenshots: N/A
• Videos: N/A
• Logs/CLI output:
  • GOTOOLCHAIN=auto go test ./pkg/ocm -count=1 -args -ginkgo.focus="Addons API client behavior"
  • GOTOOLCHAIN=auto make rosa
• Other artifacts: N/A

Breaking Changes

• No breaking changes
• Yes, this PR introduces a breaking change (describe impact and migration plan below)

Breaking Change Details / Migration Plan

N/A

Developer Verification Checklist

• Commit subject/title follows [JIRA-TICKET] | [TYPE]: <MESSAGE>.
• PR description clearly explains both what changed and why.
• Relevant Jira/GitHub issues and related PRs are linked.
• make install-hooks has been run in this clone.
• Tests were added/updated where appropriate.
• I manually tested the change.
• make test passes.
• make lint passes.
• make rosa passes.
• Documentation or repo-local agent guidance was added/updated where appropriate.
• Any risk, limitation, or follow-up work is documented.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 63772099-01f6-4853-9eca-d9549f7e20b4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olucasfreitas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [olucasfreitas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment