OCM-00000 | ci: Update bingo-tooling to v1.6.0 - #3363
OCM-00000 | ci: Update bingo-tooling to v1.6.0#3363red-hat-konflux[bot] wants to merge 1 commit into
Conversation
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: red-hat-konflux[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @red-hat-konflux[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
📝 WalkthroughWalkthroughRemoved the 🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
@red-hat-konflux[bot]: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@coderabbitai I dont understand, why Renovate is removing from the file? Is this something related to how bingo works? |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
gh pr view 3363 --repo openshift/rosa --json title,body,files,commits -q '.'
echo "---FILE CONTENT---"
gh api repos/openshift/rosa/contents/.bingo/govulncheck.mod?ref=main --jq '.content' | base64 -d
echo "---PR DIFF---"
gh pr diff 3363 --repo openshift/rosaLength of output: 3211 🏁 Script executed: #!/bin/bash
set -euo pipefail
gh api repos/openshift/rosa --jq '.default_branch'
echo "---FILE ON BASE BRANCH---"
gh api repos/openshift/rosa/contents/.bingo/govulncheck.mod?ref=master --jq '.content' | base64 -d
echo "---PR DIFF---"
gh pr diff 3363 --repo openshift/rosa
echo "---VARIABLES.MK / bingo config---"
gh api repos/openshift/rosa/contents/.bingo/variables.mk?ref=master --jq '.content' 2>/dev/null | base64 -d || true
echo "---Renovate config---"
gh api repos/openshift/rosa/contents/renovate.json?ref=master --jq '.content' 2>/dev/null | base64 -d || trueLength of output: 6564
What's happening: The There's no actual Your "gomod": {
...
"managerFilePatterns": [
"/(^|/)\\.bingo/[^/]+\\.mod$/"
],
"postUpdateOptions": [
"gomodUpdateImportPaths",
"gomodTidy"
],
...
}
Suggested fix: Add a {
"description": "Don't run gomodTidy on bingo tool mod files (they have no real Go source, tidy strips the require)",
"matchManagers": ["gomod"],
"matchFileNames": [".bingo/*.mod"],
"postUpdateOptions": ["gomodUpdateImportPaths"]
}Renovate merges Would you like me to open a follow-up issue to track updating the Renovate/Mintmaker configuration for this? |
|
/hold |
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update ( If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
This PR contains the following updates:
v1.1.4→v1.6.0Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.