Skip to content

OCM-00000 | Remove gomodTidy from postUpdateOptions - #3365

Merged
openshift-merge-bot[bot] merged 1 commit into
masterfrom
amandahla-patch-1
Jul 13, 2026
Merged

OCM-00000 | Remove gomodTidy from postUpdateOptions#3365
openshift-merge-bot[bot] merged 1 commit into
masterfrom
amandahla-patch-1

Conversation

@amandahla

@amandahla amandahla commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

PR Summary

Fix #3363 (comment)

Detailed Description of the Issue

Related Issues and PRs

Type of Change

  • feat - adds a new user-facing capability.
  • fix - resolves an incorrect behavior or bug.
  • docs - updates documentation only.
  • style - formatting or naming changes with no logic impact.
  • refactor - code restructuring with no behavior change.
  • test - adds or updates tests only.
  • chore - maintenance work (tooling, housekeeping, non-product code).
  • build - changes build system, packaging, or dependencies for build output.
  • ci - changes CI pipelines, jobs, or automation workflows.
  • perf - improves performance without changing intended behavior.

Previous Behavior

Behavior After This Change

How to Test (Step-by-Step)

Preconditions

Test Steps

Expected Results

Proof of the Fix

  • Screenshots:
  • Videos:
  • Logs/CLI output:
  • Other artifacts:

Breaking Changes

  • No breaking changes
  • Yes, this PR introduces a breaking change (describe impact and migration plan below)

Breaking Change Details / Migration Plan

Developer Verification Checklist

  • Commit subject/title follows [JIRA-TICKET] | [TYPE]: <MESSAGE>.
  • PR description clearly explains both what changed and why.
  • Relevant Jira/GitHub issues and related PRs are linked.
  • make install-hooks has been run in this clone.
  • Tests were added/updated where appropriate.
  • I manually tested the change.
  • make test passes.
  • make lint passes.
  • make rosa passes.
  • Documentation or repo-local agent guidance was added/updated where appropriate.
  • Any risk, limitation, or follow-up work is documented.

Summary by CodeRabbit

  • Chores
    • Updated automated dependency maintenance settings to preserve Go import path updates while no longer running automatic module tidying.

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 2245d2c2-5d8d-422c-afe3-17fa4f57a41c

📥 Commits

Reviewing files that changed from the base of the PR and between 4a232c4 and 6d34cac.

📒 Files selected for processing (1)
  • renovate.json

📝 Walkthrough

Walkthrough

Updated Renovate’s Go module post-update configuration to run gomodUpdateImportPaths without gomodTidy.

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is mostly empty and lacks the required problem, rationale, validation, and related issue details from the template. Fill in the PR summary, issue background, related issues/PRs, type of change, behavior before/after, and step-by-step validation.
✅ Passed checks (14 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: removing gomodTidy from postUpdateOptions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only renovate.json changed; no test files or Ginkgo titles were added or modified.
Test Structure And Quality ✅ Passed Only renovate.json changed; no Ginkgo test code was added or modified, so the test-quality check is not applicable.
Microshift Test Compatibility ✅ Passed Only renovate.json changed; no Ginkgo e2e tests or OpenShift API usages were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only renovate.json changed; no new Ginkgo tests or e2e specs were added, so SNO compatibility is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only renovate.json changed; no deployment manifests, operator code, or controllers were modified, so topology-aware scheduling is not implicated.
Ote Binary Stdout Contract ✅ Passed Only renovate.json changed; no process-level OTE binary code or stdout writes were added or altered.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only renovate.json changed; no Ginkgo e2e tests were added or modified, so there are no IPv4 or disconnected-network compatibility concerns to flag.
No-Weak-Crypto ✅ Passed Only renovate.json changed, removing gomodTidy; no weak-crypto code, custom crypto, or secret comparisons were added.
Container-Privileges ✅ Passed Only renovate.json changed; no container/K8s manifests were modified, and no new privilege settings were introduced.
No-Sensitive-Data-In-Logs ✅ Passed Only renovate.json changed; it alters Renovate config and adds no logging or sensitive-output code.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch amandahla-patch-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2026
@olucasfreitas

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2026
@openshift-ci

openshift-ci Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amandahla, olucasfreitas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [amandahla,olucasfreitas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@amandahla

Copy link
Copy Markdown
Contributor Author

/override ci/prow/e2e-presubmits-images

@openshift-ci

openshift-ci Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

@amandahla: Overrode contexts on behalf of amandahla: ci/prow/e2e-presubmits-images

Details

In response to this:

/override ci/prow/e2e-presubmits-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot
openshift-merge-bot Bot merged commit b3ea520 into master Jul 13, 2026
11 checks passed
@openshift-ci

openshift-ci Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

@amandahla: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants