fix(tray): scroll to top in the activity window on opening - #10533
Conversation
- reopening will ensure tha the list is scrolled to the top - before, the scroll location was memorized and and new notifications or conflicts were missed Assisted-by: Codex:GPT-5 Signed-off-by: Rello <github@scherello.de>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 88ef7e23a1
鈩癸笍 About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| minimumHeight: Style.wizardStandaloneWindowMinimumHeight | ||
|
|
||
| function resetActivityList() { | ||
| activityList.positionAtTop() |
There was a problem hiding this comment.
This reset only fires from Component.onCompleted or when visible changes. In the cached-window path of Systray::showActivitiesWindow(), the tray action calls show(), raise(), and requestActivate() on the existing QQuickWindow; when that window is already visible but behind another window, visible does not change, so the list keeps its old scroll offset and new items at the top can still be missed. Please trigger resetActivityList() from the existing-window open path or another activation hook rather than relying only on visibleChanged.
Useful? React with 馃憤聽/ 馃憥.
|
Artifact containing the AppImage: nextcloud-appimage-pr-10533.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
| /* | ||
| * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors | ||
| * SPDX-License-Identifier: CC0-1.0 | ||
| * | ||
| * This software is in the public domain, furnished "as is", without technical | ||
| * support, and with no warranty, express or implied, as to its usefulness for | ||
| * any purpose. | ||
| */ | ||
|
|
||
| #include "account.h" |
There was a problem hiding this comment.
Let's avoid writing C++ QTests for QML components. The window should be testable using a QtQuick Test
3 participants
Assisted-by: Codex:GPT-5