fix(cli): improve assert fake client lookup logic - #2762
Open
FirePheonix wants to merge 1 commit into
Open
Conversation
Signed-off-by: Shubham Singh <shubhsoch@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
When running the
chainsaw assertCLI command using the--resourceflag, the internal fake client previously hardcoded resource lookups to always return the very first element in the loaded file (ressources[0]). If a resource file contained multiple manifests, assertions targeting any resource other than the first one would receive the wrong object.I replaced the hardcoded index access with proper resource filtering by
Name,Namespace, andGroupVersionKind, returning a standardNotFoundAPI error if the requested object is missing.Related issue
There was the following TODO:
pkg/commands/assert/command.go: // TODO: we should improve the lookup logic hereProposed Changes
GetFninpkg/commands/assert/command.goto match objects by name, namespace, and GVK.ListFninpkg/commands/assert/command.goto filter items by namespace, GVK, and label selector.pkg/commands/assert/command_test.goto cover theresourcePathfake client path.Checklist