Skip to content

Support browser HID keys in keybindings #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jyn514 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support browser HID keys in keybindings #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/glide/browser/base/content/test/utils/browser_keys.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,13 @@ const KEYS = make_keys({
"F10": { code: "F10" },
"F11": { code: "F11" },
"F12": { code: "F12" },
"BrowserBack": { code: "BrowserBack" },
"BrowserFavorites": { code: "BrowserFavorites" },
"BrowserForward": { code: "BrowserForward" },
"BrowserHome": { code: "BrowserHome" },
"BrowserRefresh": { code: "BrowserRefresh" },
"BrowserSearch": { code: "BrowserSearch" },
"BrowserStop": { code: "BrowserStop" },

// standard
"a": { code: "KeyA" },
Expand Down Expand Up @@ -277,6 +284,13 @@ add_task(async function test_event_to_ident() {
is(to_key_notation(KEYS["Delete"]), "<Del>");
is(to_key_notation(KEYS["F1"]), "<F1>");
is(to_key_notation(KEYS["F12"]), "<F12>");
is(to_key_notation(KEYS["BrowserBack"]), "<BrowserBack>");
is(to_key_notation(KEYS["BrowserFavorites"]), "<BrowserFavorites>");
is(to_key_notation(KEYS["BrowserForward"]), "<BrowserForward>");
is(to_key_notation(KEYS["BrowserHome"]), "<BrowserHome>");
is(to_key_notation(KEYS["BrowserRefresh"]), "<BrowserRefresh>");
is(to_key_notation(KEYS["BrowserSearch"]), "<BrowserSearch>");
is(to_key_notation(KEYS["BrowserStop"]), "<BrowserStop>");
is(to_key_notation({ ...KEYS["F2"], ctrlKey: true, shiftKey: true }), "<C-S-F2>");

// Special downcast keys
Expand Down
7 changes: 7 additions & 0 deletions src/glide/browser/base/content/utils/keys.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,13 @@ const SPECIAL_KEY_MAP = new Map(Object.entries({
F10: "F10",
F11: "F11",
F12: "F12",
BrowserBack: "BrowserBack",
BrowserFavorites: "BrowserFavorites",
BrowserForward: "BrowserForward",
BrowserHome: "BrowserHome",
BrowserRefresh: "BrowserRefresh",
BrowserSearch: "BrowserSearch",
BrowserStop: "BrowserStop",

// Note: see below `DOWNCAST_SPECIAL_KEY_MAP`, these characters are treated differently
// from the rest of the ones defined above.
Expand Down