Support browser HID keys in keybindings - #349
Open
jyn514 wants to merge 1 commit into
Open
Conversation
These were present in `src/glide/browser/base/content/glide.d.ts` but never recognized by the Vim translation layer. This makes it possible to bind back/forward on my keyboard in a operating-system portable way, without special-casing Glide's Ctrl-H shortcut (which doesn't work in other browsers).
jyn514
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were present in
src/glide/browser/base/content/glide.d.tsbut never recognized by the keycode translation layer.This makes it possible to bind back/forward on my keyboard in a operating-system portable way, without special-casing Glide's Ctrl-H shortcut (which doesn't work in other browsers).
Disclosure: This was generated by an LLM. I got the idea for the change from https://configure.zsa.io/, which has WWW-Back as an option, then compared it against
GlideKeyCodesand page 132 of the HID spec for accuracy.