Skip to content

Unhide warning when schema test is skipped #1658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scpeters merged 6 commits into from
Aug 14, 2026
Merged

Unhide warning when schema test is skipped #1658

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
23e9203
Unhide warning when schema test is skipped
scpeters May 12, 2026
a3a4713
Merge branch 'main' into scpeters/unhide_schema_test_skipped_warning
scpeters May 22, 2026
9804d77
Merge branch 'main' into scpeters/unhide_schema_test_skipped_warning
scpeters Jul 20, 2026
a5eae47
Merge branch 'main' into scpeters/unhide_schema_test_skipped_warning
scpeters Aug 13, 2026
9bd3369
Convert WARNING to STATUS message to fix CI
scpeters Aug 14, 2026
271cec1
Clean up xmllint version parsing logic
scpeters Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions test/integration/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,18 +78,26 @@ if (EXISTS ${XMLLINT_EXE})
)
# typical output: "/usr/bin/xmllint: using libxml version 20913\ncompiled with: ..."
# version is formatted as a single integer, with 20913 representing 2.9.13
string(REGEX MATCH "using libxml version [0-9]+" XMLLINT_VERSION_STRING ${XMLLINT_VERSION_OUTPUT})
string(REPLACE "using libxml version " "" XMLLINT_VERSION ${XMLLINT_VERSION_STRING})
# schema test is broken with very new versions of xmllint
# https://github.com/gazebosim/sdformat/issues/1656
# enable schema test if xmllint is older than 2.15.0
if("${XMLLINT_VERSION}" LESS 21500)
string(REGEX MATCH "using libxml version [0-9]+" XMLLINT_VERSION_STRING "${XMLLINT_VERSION_OUTPUT}")
string(REPLACE "using libxml version " "" XMLLINT_VERSION "${XMLLINT_VERSION_STRING}")
if("${XMLLINT_VERSION}" STREQUAL "")
message(WARNING "Unable to identify xmllint version. schema_test won't be run")
elseif("${XMLLINT_VERSION}" LESS 10000)
message(WARNING "Old version of xmllint (${XMLLINT_VERSION_STRING}) detected. schema_test won't be run")
elseif("${XMLLINT_VERSION}" LESS 21500)
# schema test is broken with very new versions of xmllint
# https://github.com/gazebosim/sdformat/issues/1656
# enable schema test if xmllint is older than 2.15.0
set (tests ${tests} schema_test.cc)
else()
gz_build_warning("xmllint version is too new (${XMLLINT_VERSION}). schema_test won't be run")
# TODO: convert to WARNING when https://github.com/gazebosim/sdformat/issues/1656
# is resolved on supported platforms. It currently fails on Ubuntu 26.04
message(STATUS "WARNING: xmllint version (${XMLLINT_VERSION}) is too new; "
"schema_test won't be run. "
"See https://github.com/gazebosim/sdformat/issues/1656")
endif()
else()
gz_build_warning("xmllint not found. schema_test won't be run")
message(WARNING "xmllint not found. schema_test won't be run")
endif()

gz_build_tests(TYPE ${TEST_TYPE}
Expand Down
Loading