Unhide warning when schema test is skipped - #1658
Merged
Merged
Conversation
Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
65 tasks
Member
Author
|
From Ubuntu Resolute CI: |
scpeters
marked this pull request as ready for review
May 12, 2026 20:54
scpeters
commented
May 22, 2026
caguero
reviewed
Aug 13, 2026
caguero
approved these changes
Aug 13, 2026
Add TODO with link to bug to convert back to WARNING when bug is fixed on Ubuntu 26.04 Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
* Quote string variables in case they are empty * Warn on empty version string * Warn on version string below 10000 to handle dot-decimal strings such as 2.15.1 instead of 21501 Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Unhides a warning added in #1655
Summary
The schema integration test fails when run with very new versions of
xmllint. This was discovered when adding CI with Ubuntu 26.04 in #1655, and logic to disable the test with a warning was added in that PR. Unfortunately, the warning is not currently being reported due to the order in whichgz_build_warningis processed ingz_configure_buildeven though the test is skipped:This unhides the warning by switching to
message(WARNING ""), in a similar manner to gazebosim/gz-transport#565.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.Backports: If this is a backport, please use Rebase and Merge instead.