Skip to content

Fix release kit action #2944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
inlined merged 4 commits into from
Aug 14, 2026
Merged

Fix release kit action #2944

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f97c164
fix(ci): remove workspace flags and support target_branch parameter
inlined Aug 13, 2026
b1c5c19
fix(ci): use public registry for npm ci during build step
inlined Aug 13, 2026
6fcc767
fix(ci): pass target_branch via env to resolve zizmor template-injection
inlined Aug 13, 2026
587c3a0
chore(ci): remove target_branch parameter in favor of github.ref_name
inlined Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions .github/workflows/release-kit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,11 @@ jobs:
with:
node-version: "24"

- name: Install Dependencies
run: npm ci

- name: Run Workspace Tests
run: npm test --workspace=${{ inputs.target_kit }}
- name: Install Dependencies & Run Tests
working-directory: ${{ inputs.target_kit }}
run: |
npm ci
npm test

# =========================================================
# 2. RELEASE JOB (Elevated Permissions: Write)
Expand All @@ -76,14 +76,13 @@ jobs:
steps:
- name: Checkout repository
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # zizmor: ignore[artipacked]
with:
ref: kits

- name: Setup Node.js
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version: "24"
registry-url: "https://wombat-dressing-room.appspot.com"
always-auth: false

- name: Configure Git User
if: ${{ !inputs.dry_run }}
Expand Down Expand Up @@ -142,11 +141,10 @@ jobs:
echo "target_tag=$TARGET_TAG" >> $GITHUB_OUTPUT

- name: Install Dependencies & Build
env:
TARGET_KIT: ${{ inputs.target_kit }}
working-directory: ${{ inputs.target_kit }}
run: |
npm ci
npm run build --workspace=$TARGET_KIT
npm ci --registry=https://registry.npmjs.org
npm run build

- name: Bump Version (Clear CHANGELOG on Stable Release Only)
id: versioning
Expand Down Expand Up @@ -215,7 +213,9 @@ jobs:

- name: Push Version Commit & Tags to Branch
if: ${{ !inputs.dry_run }}
run: git push origin kits --follow-tags
env:
REF_NAME: ${{ github.ref_name }}
run: git push origin "$REF_NAME" --follow-tags

- name: Publish to NPM
# zizmor: ignore[use-trusted-publishing]
Expand Down Expand Up @@ -251,6 +251,7 @@ jobs:
VERSION: ${{ steps.versioning.outputs.version }}
IS_PRERELEASE: ${{ inputs.is_prerelease }}
NOTES: ${{ steps.changelog.outputs.notes }}
REF_NAME: ${{ github.ref_name }}
run: |
PRERELEASE_FLAG=""
if [ "$IS_PRERELEASE" = "true" ]; then
Expand All @@ -260,5 +261,5 @@ jobs:
gh release create "$TAG_NAME" \
--title "$PKG_NAME v$VERSION" \
--notes "$NOTES" \
--target kits \
--target "$REF_NAME" \
$PRERELEASE_FLAG
Loading