Skip to content

fix: persist DEFAULT_CHANNEL in prepare-release #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thomasmaas wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: persist DEFAULT_CHANNEL in prepare-release #795

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,6 +612,9 @@ prepare-release: ## Generates a makefile that will override environment variable
echo -e "#Release default values\\nIMG=$(IMAGE_TAG_BASE):$(IMG_TAG)\nBUNDLE_IMG=$(IMAGE_TAG_BASE)-bundle:$(IMG_TAG)\n\
CATALOG_IMG=$(IMAGE_TAG_BASE)-catalog:$(IMG_TAG)\nCOREDNS_IMG=$(COREDNS_IMAGE_TAG_BASE):$(IMG_TAG)\nCHANNELS=$(CHANNELS)\n\
BUNDLE_CHANNELS=--channels=$(CHANNELS)\nVERSION=$(VERSION)" > $(RELEASE_FILE)
ifneq ($(origin DEFAULT_CHANNEL), undefined)
echo -e "DEFAULT_CHANNEL=$(DEFAULT_CHANNEL)\nBUNDLE_DEFAULT_CHANNEL=--default-channel=$(DEFAULT_CHANNEL)" >> $(RELEASE_FILE)
endif
$(MAKE) set-image-refs
$(MAKE) bundle
$(MAKE) helm-build VERSION=$(VERSION)
Expand Down
Loading