fix: persist DEFAULT_CHANNEL in prepare-release - #795
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesRelease channel configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The `prepare-release` target writes CHANNELS/BUNDLE_CHANNELS to make/release.mk but never persisted DEFAULT_CHANNEL/BUNDLE_DEFAULT_CHANNEL. This meant subsequent `make bundle` invocations on a release branch silently fell back to the Makefile default, producing bundles without an explicit default-channel annotation. Conditionally append DEFAULT_CHANNEL/BUNDLE_DEFAULT_CHANNEL to release.mk when the caller passes DEFAULT_CHANNEL, mirroring the existing ifneq guard at the top of the Makefile. Callers who don't pass DEFAULT_CHANNEL see no behavior change. Same class of bug fixed for limitador-operator in Kuadrant/limitador-operator#268 / #269. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Thomas Maas <thomas@webtypes.com>
fb40391 to
08d61de
Compare
Summary
DEFAULT_CHANNELandBUNDLE_DEFAULT_CHANNELto the values written tomake/release.mkby theprepare-releasetargetWhy
prepare-releasealready persistedCHANNELS/BUNDLE_CHANNELSintomake/release.mk, but never did the same forDEFAULT_CHANNEL/BUNDLE_DEFAULT_CHANNEL. This meant any subsequentmake bundleinvocation on a release branch silently fell back to the Makefile default (unset), producing bundles without an explicitchannel.default.v1annotation.Same class of bug fixed for limitador-operator in Kuadrant/limitador-operator#268 / Kuadrant/limitador-operator#269.
Test plan
make prepare-release VERSION=0.0.0-test CHANNELS=stable DEFAULT_CHANNEL=stablewrites both channel values tomake/release.mkbundle.Dockerfileandbundle/metadata/annotations.yamlcontainchannel.default.v1=stable🤖 Generated with Claude Code
Summary by CodeRabbit