feat(nvidia): add top-k top-p sampling provider - #922
Draft
voltjia wants to merge 1 commit into
Draft
Conversation
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TopKTopPSamplingFromLogitsoperator undersrc/native/cuda/nvidia/ops/top_k_top_p_sampling_from_logits/.top_k_firstandjointfiltering semantics with counter-based deterministic seed and offset handling.Motivation
The canonical
TopKTopPSamplingFromLogitsAPI has no native NVIDIA implementation. This change makes the aligned API usable on NVIDIA without relying on workload-specific sampling operators, while preserving deterministic seed and offset behavior and supporting both public filter orders.No linked issue.
Type of Change
feat- new feature / new operator / new platformfix- bug fixperf- performance improvement (no behavioral change)refactor- code restructuring without behavior changetest- adding or fixing tests onlydocs- documentation onlybuild/ci- build system or CI configurationchore- tooling, formatting, or other non-code changesPlatforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
Hardware: NVIDIA A100-SXM4-80GB
Image:
accelerator-dev/nvidia:latestTest Results on Supported Platforms
Focused NVIDIA validation
Targeted wheel SHA256:
8a8fbea8318632c50063bd62bd1912eb0b6ca38439b3882b72e5a8b4a96dbfd1Formatting checks: clang-format 21.1.8 dry-run passed; Ruff 0.15.22 format and lint checks passed.
Benchmark / Performance Impact
N/A. There is no previous native NVIDIA provider to use as a baseline, and this Draft PR validates correctness rather than throughput.
Notes for Reviewers
jointusesrandom * min(top_p * full_probability_mass, top_k_cumulative_probability)and is intentionally distinct fromtop_k_first.seedandoffset + rowusing a counter-based generator.deterministic=trueandcheck_nan=false.top_k,top_p, and optionalindicesmust be contiguous host tensors.