fix(build): separate linked operator allowlist - #923
Draft
voltjia wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
INFINI_OPS_LINKED_OPSso linked provider selection can be narrower than the generated operator surface.Motivation
WITH_LINKED=ONcurrently reusesINFINI_OPS_OPSfor every linked provider. A build that needs nativetopk_softmaxand linked FlashAttention therefore tries to resolve the optional vLLM provider fortopk_softmax, even though the native NVIDIA implementation is selected. The separate allowlist keeps the public operator surface intact while resolving only providers the build actually uses.Type of Change
feat- new feature / new operator / new platformfix- bug fixperf- performance improvement (no behavioral change)refactor- code restructuring without behavior changetest- adding or fixing tests onlydocs- documentation onlybuild/ci- build system or CI configurationchore- tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
Test Results on Supported Platforms
Benchmark / Performance Impact
N/A - build-time provider selection only.
Notes for Reviewers
This PR is stacked on #922 because the downstream integration requires both changes. The commit is independent and can be rebased onto
masterafter #922 merges. With no explicitINFINI_OPS_LINKED_OPS, existing builds keep usingINFINI_OPS_OPSfor linked providers.