Skip to content

fix(review): pin reusable fix scheduler source - #710

Closed
seonghobae wants to merge 2 commits into
mainfrom
fix/pin-review-fix-canonical-source
Closed

fix(review): pin reusable fix scheduler source#710
seonghobae wants to merge 2 commits into
mainfrom
fix/pin-review-fix-canonical-source

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Resolve the scheduler implementation from the called workflow's own job.workflow_repository and immutable job.workflow_sha instead of mutable main.
  • Fail closed unless the source resolves to ContextualWisdomLab/.github at a 40-character commit SHA.
  • Honor the declared autofix_workflow and autofix_repository inputs instead of silently overriding them.
  • Keep the legacy canonical_ref input as a no-op compatibility field so existing callers do not break.

Security rationale

A caller can pin the reusable workflow file while the called workflow still executes a mutable checkout. GitHub's called-workflow identity context provides the authoritative repository and SHA for co-located source. Using it closes that hidden mutable-code/write-token path without requiring caller-supplied trust data.

Validation

  • Based the source identity on GitHub's documented job.workflow_repository and job.workflow_sha reusable-workflow contexts.
  • Added fail-closed repository and SHA validation before checkout.
  • The existing scheduler self-test still runs after the immutable checkout.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 1 minute

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c098bb33-cdee-4d2d-8014-17c8ca00f61f

📥 Commits

Reviewing files that changed from the base of the PR and between 5983b41 and f743b68.

📒 Files selected for processing (1)
  • .github/workflows/pr-review-fix-scheduler.yml

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Copy Markdown
Contributor Author

Closing as superseded by #704. That PR pins reusable execution to GitHub's immutable job.workflow_repository/job.workflow_sha rather than a caller-supplied SHA, adds regression contracts, and also carries the hourly bounded-retry change. The separate proposal to make autofix_repository/autofix_workflow caller-selectable should be reviewed independently because it changes a privileged dispatch trust boundary.

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant