fix(automation): run securely pinned review repair every hour - #704
fix(automation): run securely pinned review repair every hour#704seonghobae wants to merge 4 commits into
Conversation
|
Warning Review limit reached
Next review available in: 27 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthrough재시도 최소 대기 시간을 24시간에서 1시간으로 변경했습니다. 스케줄을 매시 23분으로 변경했습니다. 체크아웃은 호출된 워크플로의 저장소와 확인된 SHA를 사용합니다. 관련 동작을 테스트로 검증합니다. Changes스케줄러 동작 및 소스 제어
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
Source-pin design independently verified against GitHub's current Actions context reference: for jobs defined by a reusable workflow, |
|
@coderabbitai review Please review the exact current head of the hourly review-repair scheduler. Focus on immutable called-workflow source binding, one-dispatch bounds, same-head retry timing, least-privilege permissions, and fail-closed behavior. |
|
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head12964088023f48cf6a90089e2439226b1402b5e6. -
Head SHA:
12964088023f48cf6a90089e2439226b1402b5e6 -
Workflow run: 30841879924
-
Workflow attempt: 1
Coverage evidence
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow: pr-review-fix-scheduler.yml"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow: pr-review-fix-scheduler.yml"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["Test (2 files)"]
S2 --> I2["regression suite"]
I2 --> R2["Review risk: Test (2 files)"]
R2 --> V2["targeted test run"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage Decision
Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow: pr-review-fix-scheduler.yml"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow: pr-review-fix-scheduler.yml"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["Changed file: requirements-strix-ci.txt"]
S2 --> I2["repository behavior"]
I2 --> R2["Review risk: Changed file: requirements-strix-ci.txt"]
R2 --> V2["required checks"]
Evidence --> S3["Test (2 files)"]
S3 --> I3["regression suite"]
I3 --> R3["Review risk: Test (2 files)"]
R3 --> V3["targeted test run"]
|
df2eaf9 to
ab5b5f5
Compare
|
@coderabbitai review |
1 similar comment
|
@coderabbitai review |
✅ Action performedReview finished.
|
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current heade01e52b32d237f16ce614b1760469f9c6f64a3c4. -
Head SHA:
e01e52b32d237f16ce614b1760469f9c6f64a3c4 -
Workflow run: 30900327985
-
Workflow attempt: 1
Coverage evidence
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow: pr-review-fix-scheduler.yml"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow: pr-review-fix-scheduler.yml"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["Changed file: requirements-strix-ci.txt"]
S2 --> I2["repository behavior"]
I2 --> R2["Review risk: Changed file: requirements-strix-ci.txt"]
R2 --> V2["required checks"]
Evidence --> S3["Test (2 files)"]
S3 --> I3["regression suite"]
I3 --> R3["Review risk: Test (2 files)"]
R3 --> V3["targeted test run"]
Problem
The merge scheduler already revisits merge readiness every 15–30 minutes, but unresolved review-feedback autofix ran only every two hours and would not revisit the same current head for 24 hours. Review-addressable pull requests could therefore remain idle long after feedback appeared.
The reusable workflow also checked out scheduler code from mutable
main, even when callers referenced the workflow at an immutable SHA. In a reusable workflow, the ordinarygithubcontext belongs to the caller, so the privileged implementation must be bound to the called workflow's own resolved source.Change
job.workflow_repositoryat immutablejob.workflow_sha;canonical_refonly as an ignored deprecated compatibility input so existing pinned callers can upgrade without a coordinated break;Safety
The scheduler does not bypass reviews or checks. It only dispatches the existing bounded autofix workflow; merge eligibility continues to be decided by the independent merge scheduler and repository rules. The deprecated input is never read and cannot select trusted code.
Verification
job.workflow_repositoryandjob.workflow_sha;Summary by CodeRabbit
개선 사항
canonical_ref입력과의 호환성이 유지됩니다.테스트