refactor: harmonize functions to format/functions.rs - #943
Merged
Conversation
Its-Just-Nans
commented
Aug 17, 2026
Its-Just-Nans
commented
Member
- The PR title must conform to Conventional Commits and start with one of the types specified by the Angular convention.
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
The refactoring looks solid overall. The code has been reorganized to consolidate format-related functions into src/format/functions.rs, which improves code structure. The logic appears to be correctly preserved across the move, with no functional changes beyond better organization.
One minor issue found: a typo in a comment that should be corrected.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 17, 2026
Member
Author
|
Seems like github is githubing (per https://www.githubstatus.com/) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.