fix: the alignment value should be inside the data alignment - #929
Merged
Conversation
Its-Just-Nans
enabled auto-merge
August 13, 2026 09:16
Contributor
There was a problem hiding this comment.
The changes correctly implement storage of the alignment value in the DataStreamAlignment extra field. The implementation properly validates padding length requirements, stores the alignment value, and writes it according to the ZIP specification format.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Little mistake in github.com//pull/879
It was previously like this (line 1223)
zip2/src/write.rs
Lines 1221 to 1229 in 98d6d23
But the alignment is not written to