feat: change aes_mode to aes_settings() in ZipFileData - #925
Merged
Conversation
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
This refactoring correctly removes the duplicate aes_mode variable from ZipFileData and consolidates AES mode retrieval through the extra fields API. The feature gating for AexEncryption is properly implemented, and all reader code paths have been updated consistently. The changes maintain backward compatibility and don't introduce any merge-blocking defects.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Its-Just-Nans
changed the title
aes_mode to aes_settings()
Its-Just-Nans
changed the title
aes_mode to aes_settings() aes_mode to aes_settings() in ZipFileData
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR title must conform to Conventional Commits and start with one of the types specified by the Angular convention.
remove the
aes_modevariable inZipFileDatasince it's kinda duplicate with the extraFieldGate the extra field
AexEncryptionto be used only inaes-crypto