feat(openai): reconcile gpt-5.6 defs with upstream (cacheWrites + tiers) - #4
Merged
Merged
Conversation
Upstream independently shipped gpt-5.6 sol/terra/luna after the fork did, so the entries collide and differ. Adopt upstream's cacheWritesPrice and flex/priority service tiers (cost was under-counted without them); keep the fork's Luna 1.05M contextWindow + longContextPricing, reasoning-effort defaults (high/medium/low), and descriptions. All tier contextWindows pinned to 1_050_000 (upstream tied them to its 400K Luna figure, which is still unverified against OpenAI docs). - openai.ts: add cacheWritesPrice + tiers to the three gpt-5.6 entries - openai-native.spec: assert Sol cacheWritesPrice 6.25 + priority tier present - FORK.md: record the collision, the index.ts default-model divergence (openAiNativeDefaultModelId vs upstream hardcoded gpt-4o), next-sync guidance, and GPT-5.6 provider coverage (Bedrock GA-via-mantle deferred; Vertex not offered) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reconciles the fork's
gpt-5.6(Sol/Terra/Luna) model defs with upstream, which independently shipped the same three models after the fork did (so the entries now collide and differ).cacheWritesPrice(Sol 6.25, Terra 3.125, Luna 1.25) and flex/priority servicetiers. Without these the fork under-counted cost (no 1.25× cache-write price, no flex/priority tiers).contextWindow: 1_050_000+longContextPricing, the reasoning-effort defaults (Sol high / Terra medium / Luna low), and the descriptions.contextWindows pinned to1_050_000(upstream tied them to its 400K Luna figure — still unverified against OpenAI docs).Why
The fork shipped gpt-5.6 in #3 (
ded80951d); upstream then shipped its own (a441e02bd). This cherry-pick gets both the cost fields and the fork's intended behavior right, and shrinks the guaranteed conflict on the next upstream sync.Files
packages/types/src/providers/openai.ts— addcacheWritesPrice+tiersto the three entries.src/api/providers/__tests__/openai-native.spec.ts— assert SolcacheWritesPrice6.25 + aprioritytier.FORK.md— record the collision, theindex.tsdefault-model divergence (openAiNativeDefaultModelIdvs upstream's hardcoded"gpt-4o"), next-sync guidance, and GPT-5.6 provider coverage.Verification
pnpm --filter @roo-code/types check-types✅openai-native.spec✅ 53/53 (incl. new assertions);fetchers/openrouter.spec✅reasoning.spec+model-params.spec— 22 failures = unchanged fork baseline (stale upstream budget/binary fixtures), no new failuresturbo lint✅Provider coverage (follow-on request — verified 2026-07-14)
bedrock-mantle; the fork's Bedrock provider is Converse-only, so a registry entry would 400. Deferred — needs a separate mantle-Responses transport.Follow-up
Merge
local/gpt-5.6-reconcile→local/daily-driveronce reviewed (per the PR #3 workflow).🤖 Generated with Claude Code