Preserve color through linear HDR bloom - #489
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
.fledrecordings and decode RGB8 playback into linear lightWhy
Mapped renders were lifting dark shadows and shifting yellow midtones toward orange because blur and bloom mixed display-encoded 8-bit values. Repeated quantization also reduced useful highlight and shadow precision.
This keeps intermediate rendering linear and high precision, then quantizes once at the display/recording boundary. The result preserves deeper blacks, yellow midtones, highlight detail, and the established HDR bloom appearance.
Validation
npm test— 712 tests passednpm run build— passednpm run test:integration -- moviemaker-preview— passed