Feature/add album view - #240
Open
JohnKuan wants to merge 14 commits into
Open
Conversation
added 11 commits
December 2, 2017 00:18
fix image duplication issue on close and done buttons
change the closeButton to ic_close
fix constraints assignment that was mapped wrongly fix chevron image align
Owner
|
@JohnKuan Resolve conflicts to be merged 🙇 |
added 3 commits
December 14, 2017 17:04
…e/add-album-view * 'master' of https://github.com/ytakzk/Fusuma: update swift version update podspec ytakzk#239 added uitesting update -destination remove some @objc warnings and prevent crashing in simulator update example swift version no message upgrade xcode image to 9.2 Swift 4 compatibilty # Conflicts: # Example/FusumaExample.xcodeproj/project.pbxproj
fix errors after merging from master branch
Author
|
@ytakzk okay, should be resolved now |
Collaborator
|
@JohnKuan New maintainer here. Sorry—still just a couple conflicts. I can merge this immediately after they're resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is meant to solve https://github.com/ytakzk/Fusuma/issues/29.
There are are substantial changes with regards to how FusumaViewController has to be created.
Firstly, it will require and rely on UINavigationController for the left and right buttons as well as the newly added album selection button. This will no longer require the menuView and the associated buttons with it and hence it was removed in this PR. This will also solve iPhone X layout issue since Apple has made it more applicable to use UINavigationBar, especially to support iPhone X's safe area region.
Next, FusumaViewController has to be wrapped in UINavigationController upon presentViewController method. This is so as to fulfill the requirements in point 1. I have not added a method to create FusumaViewController as a UINavigationController with the current FusumaViewController as rootViewController, since in my use case I can simply call UINavigationController. However, I do understand that it is not wise to give other users the option not to have the UINavigationController in this implementation.
These are the 2 major changes from the existing master branch other than the addition of the album selection table viewcontroller and the respective methods to populate FSAlbumView with the selected PHAssetCollection.
I still believe this is W.I.P and should not be merged at the moment and I would like to hear your feedback with regards to this implementation.