Skip to content

rdk: Unfilter passing graphics, media, and video tests in nplb_loader_filter.json - #11490

Open
niranjanyardi wants to merge 22 commits into
youtube:mainfrom
niranjanyardi:unfilter_graphics_nplb_tests
Open

rdk: Unfilter passing graphics, media, and video tests in nplb_loader_filter.json#11490
niranjanyardi wants to merge 22 commits into
youtube:mainfrom
niranjanyardi:unfilter_graphics_nplb_tests

Conversation

@niranjanyardi

Copy link
Copy Markdown
Member

Unfilter verified passing graphics, window, media, and video tests from nplb_loader_filter.json.

With the Wayland display environment export fix (PR #11486), Wayland window size queries, EGL display initialization, and video/audio playback pipelines succeed on RDK.

Verified on live RDK hardware over SSH:

  • SbWindowGetSizeTest.SunnyDay passes.
  • MaximumPlayerConfigurationExplorerTests/* (all 10) pass.
  • MultiplePlayerTest.SunnyDay passes.
  • SbMediaCanPlayMimeAndKeySystem.MinimumSupport passes.
  • SbMediaSetAudioWriteDurationTests/* (all 4) pass.
  • SbPlayerGetAudioConfigurationTests/* (all 840) pass/skip cleanly.
  • SbPlayerGetMediaTimeTests/* (all 560) pass.
  • SbPlayerTest.* (all 6) pass.
  • VerticalVideoTests/* passes.
  • SbPlayerWriteSampleTests/* narrowed down to SbPlayerWriteSampleTests/SbPlayerWriteSampleTest.LimitedAudioInput/* (the only hung sub-suite).

Issue: 508253341

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the test filter configuration in nplb_loader_filter.json for the evergreen-arm-hardfp-rdk platform. It removes numerous tests from the failing_tests list, including player, media, and window size tests, and refines the SbPlayerWriteSampleTest filter to only exclude LimitedAudioInput. There are no review comments, and I have no feedback to provide.

@github-actions

Copy link
Copy Markdown
Contributor

🤖 Gemini Suggested Commit Message


starboard: Unfilter passing RDK NPLB tests

Remove verified passing graphics, window, media, and video tests from
the NPLB loader filter for the Evergreen RDK platform. These tests
now succeed following the Wayland display environment export fix,
which corrected window size queries and EGL initialization.

Verified tests include SbWindowGetSize, MultiplePlayerTest,
SbMediaCanPlayMimeAndKeySystem, and various SbPlayer functionality.
SbPlayerWriteSampleTests is now narrowed down to the specific
sub-suite that continues to hang.

Issue: 508253341

💡 Pro Tips for a Better Commit Message:

  1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
  2. Re-run the Generator: Post a comment with: /generate-commit-message

@niranjanyardi
niranjanyardi requested a review from jonastsai July 24, 2026 03:16
@niranjanyardi
niranjanyardi force-pushed the unfilter_graphics_nplb_tests branch 4 times, most recently from 52dcd87 to 197e2fb Compare July 29, 2026 01:21
@niranjanyardi
niranjanyardi requested review from arjungm and oxve July 29, 2026 19:08
@niranjanyardi
niranjanyardi force-pushed the unfilter_graphics_nplb_tests branch from 6395850 to a00e163 Compare July 30, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant