Add token asset upload flow#143
Open
rossgalloway wants to merge 5 commits into
Open
Conversation
Move the tokenAssets image tooling into the CMS so token editors can prepare logo files without leaving the app. - Add token and chain asset forms with PNG generation and draft persistence - Add ERC-20 name lookup and fork-aware GitHub PR route handlers - Link the upload flow from token lists and token detail pages - Document repository target and RPC configuration
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rossgalloway
marked this pull request as ready for review
July 23, 2026 19:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move the tokenAssets image-upload tooling into the CMS so token editors can prepare and submit logos without leaving the metadata application. Add the token-logo download support from
feat/add-token-logos, keepyearn/tokenAssetsas the asset source of truth, and expose the new workflow from the tokens list and token detail pages.This PR is stacked on #142 and should be reviewed after the Next.js migration.
How to review
Start with
packages/app/src/routes/TokenAssetUpload.tsxandpackages/app/src/lib/tokenAssetUpload.tsfor the client workflow. Then reviewpackages/app/src/server/tokenAssetsandpackages/app/app/api/token-assetsfor validation, ERC-20 name resolution, and fork-aware GitHub PR creation.Happy path: open
/tokens, select Add token logo, provide a chain/address and SVG, confirm both PNG previews, review the generated PR metadata, and submit with a GitHub-authenticated CMS session. Token detail pages should prefill the upload form.Test plan
bun install --frozen-lockfilebun run --cwd packages/app tslintbun run lintbun run buildRisk / impact
The upload endpoint uses the signed-in user's GitHub token to create a branch and pull request in
yearn/tokenAssets, falling back to the user's fork when direct writes are unavailable. It does not write to the tokenAssets default branch directly. Repository targets and RPC endpoints are configurable through server-only environment variables; rollback is a revert of this PR.