[Misc] Fix SonarQube issues java:S1066 and java:S5778

[claude]

Jira URL

None — this is a [Misc] SonarQube cleanup commit.

Changes

Description

Fixes the two remaining mechanical SonarCloud issues in this repository.

Rule	Fixed	What was done
java:S1066	1	merged the nested if (this.content == null) into its enclosing if (isContentChecked()) in AbstractBoxMacro, keeping both explanatory comments above the merged condition
java:S5778	1	extracted new WordBlock("not existing") out of the assertThrows lambda in BlockTest so only replaceChild() can throw inside it

Open issues for these rules on SonarCloud

Clarifications

• The java:S1066 change is behaviour-preserving: the inner if was the only statement in the
  outer one and there is no else on either, so A && B is exactly the original control flow.
• The rest of the repository's open issues were reviewed and deliberately not touched, because
  they are refactors or API changes rather than cleanups: java:S127 (13, loop-counter
  reassignment), java:S3252 (34, static-access qualifier — renaming the qualifier loses which
  parser's escape char is meant), java:S5961 (assertion counts), java:S6035 (2 — the flagged
  regexes are public static final String constants, so changing their value is a Revapi
  constantValueChanged break), java:S3415 (2 — one of the two files already carries a
  @SuppressWarnings("java:S5785") comment explicitly warning that swapping those arguments would
  stop testing the equals() contract), and the single src/main java:S1130.

Screenshots & Video

N/A

Executed Tests

mvn install -Plegacy,quality -fae -pl xwiki-rendering-api,xwiki-rendering-macros/xwiki-rendering-macro-box

BUILD SUCCESS — 440 tests run, 0 failures, 0 errors, 0 skipped.

Expected merging strategy

Squash and merge into master. No backport needed.

Related

Part of one SonarQube sweep across the three repositories:

• xwiki-platform: [Misc] Remove unthrowable exceptions declared by test methods (SonarQube java:S1130) xwiki-platform#6108
• xwiki-commons: [Misc] Fix various SonarQube issues in test code (java:S125, java:S1130, java:S5778) xwiki-commons#1879
• xwiki-rendering: [Misc] Fix SonarQube issues java:S1066 and java:S5778 #403

---

Generated by Claude Code