[Misc] Use try-with-resources in TestDataParser (SonarQube java:S2093)

[claude]

Jira URL

None — this is a [Misc] SonarQube cleanup commit.

Changes

Description

Fixes the one genuinely actionable java:S2093 issue in the repository: TestDataParser.parse opened a BufferedReader and closed it in a finally, which is exactly what try-with-resources is for.

• The reader declaration moves into the try header, and the finally { reader.close(); } goes away.
• The "Resources should always be encoded as UTF-8" comment moves with the declaration it explains.
• Behaviour is unchanged except for the better case: if the body throws and close() throws, the close failure is now recorded as a suppressed exception instead of replacing the original one.

Clarifications

• This is deliberately a small PR. The rest of xwiki-rendering's open SonarCloud backlog is not mechanical fodder: what remains is refactors (S127, S135, S3776), renames and API-shape changes (S1214, S2386, S1452, S2176), rules on the project denylist, and pools already analysed and rejected in earlier sweeps (S1118 — adding a private constructor to a public final class XxxUtil in the exported wikimodel packages removes the implicit public constructor and fails Revapi; S6126 — the wikimodel parser-test fixtures cannot be reproduced byte-for-byte by a text block).
• The second open S2093 (AbstractInternalRenderingTest L160) is not fixed: its finally restores rendering-context state (MutableRenderingContext.pop() + executionContextManager.popContext()), it does not close a resource, so try-with-resources does not apply.

Screenshots & Video

N/A — no UI change.

Executed Tests

mvn install -Plegacy,quality -pl xwiki-rendering-test,xwiki-rendering-integration-tests

xwiki-rendering-integration-tests is included on purpose: TestDataParser has almost no tests of its own, but that module drives every .test fixture file through it, so it is what actually exercises this change.

BUILD SUCCESS — Tests run: 1532, Failures: 0, Errors: 0, Skipped: 0.

Expected merging strategy

• Prefers squash: Yes
• Backport on branches: none — cleanup only, no behaviour change.

Related

Part of the same SonarQube sweep as xwiki/xwiki-commons#1878 and the sibling PR in xwiki-platform.

---

Generated by Claude Code