Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
recordの UUID を DB 側で採番するようにDateTime<Utc>に統一してタイムゾーン情報を保持し、API返却はRFC3339にするFromトレイトでpanicやexpectを使用せず、TryFromでResultを返すように#[serde(rename_all = "camelCase")]を使用するリファクタcrates/usecase/src/user/records.rsでレコードを全権取得せずクエリを厳密にしてパフォーマンスを向上タイムゾーンに関するリファクタの詳細
DateTime<Utc>に統一してタイムゾーン情報を保持し、API返却はRFC3339にするリファクタ前
TIMESTAMPTZ(タイムゾーン付き)NaiveDateTime(タイムゾーンなし)Utc::now().naive_utc()で取得後に.naive_utc()でタイムゾーン情報を消去.to_string()使用で RFC3339 未対応リファクタ後
DateTime<Utc>に統一し、レスポンスは.to_rfc3339()を使用TIMESTAMPTZは維持DateTime<Utc>に統一)