qcow_tool_wrapper: Add progress reporting for import and export - #7191
Open
last-genius wants to merge 3 commits into
Open
qcow_tool_wrapper: Add progress reporting for import and export#7191last-genius wants to merge 3 commits into
last-genius wants to merge 3 commits into
Conversation
Contributor
Author
|
I've tested this code on top of the xs-opam PR, manually verifying that the progress is reported correctly now. I ran VDI and VM export/import tests for VHD and QCOW2 to make sure there aren't any regressions. |
psafont
reviewed
Jul 22, 2026
Comment on lines
+45
to
+46
| Xapi_stdext_pervasives.Pervasiveext.finally | ||
| (fun () -> |
Member
There was a problem hiding this comment.
Using the patterns protect ~finally @@ fun () -> or let@ () = protect ~finally in after defining protect as let protect ~finally f = Pervasives.finally f finally will keep indentation and reduce the diff
Contributor
Author
There was a problem hiding this comment.
Fixed, together with another issue where waitpid and cleanup would only be called in the None arm of match pipe_read
last-genius
force-pushed
the
asv/26.1-fix-percent
branch
from
July 22, 2026 14:32
fd5170b to
b5c1e04
Compare
This removes the duplicated logic (Vhd_qcow_parsing.run_tool and Vhd_tool_wrapper.run_vhd_tool were pretty much the same function with minor differences). Vhd_qcow_parsing.run_tool will now try to read back the progress percentages reported over stdout if ~output_fd was not specified, following Vhd_tool_wrapper.run_vhd_tool's behaviour Signed-off-by: Andrii Sultanov <andriy.sultanov@vates.tech>
Since progress reporting now takes up stdout, this requires passing the output file as another file descriptor. Signed-off-by: Andrii Sultanov <andriy.sultanov@vates.tech>
Tracking-reference: XCPNG-3562 Signed-off-by: Andrii Sultanov <andriy.sultanov@vates.tech>
last-genius
force-pushed
the
asv/26.1-fix-percent
branch
from
July 22, 2026 14:40
b5c1e04 to
a700e9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on xapi-project/xs-opam#771 being merged for progress reporting to be fixed completely.
Proceeds in three steps:
run_toolto use the same code (with the same progress reading logic)qcow2-to-stdoutscript)