fix(ui): use 1Password brand icon - #316
Merged
Merged
Conversation
siisee11
enabled auto-merge (squash)
July 16, 2026 05:22
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
onequery-landing | ccfd507 | Commit Preview URL Branch Preview URL |
Jul 16 2026, 05:23 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-Line Summary
Show the official 1Password brand mark instead of a generic key icon in provider icon surfaces.
User-Facing Changes
onepasswordprovider icon in the app UI and landing brand icon registry to use the Simple Icons 1Password mark.Why This Changed
The previous icon was a generic key outline, which made 1Password less recognizable beside providers that already use brand-specific marks.
How It Changed
si1passwordfromsimple-icons.onepasswordthrough the existing Simple Icons wrapper inpackages/uiandapps/landing.Bug Fixes
onepasswordno longer appears as a generic key icon.Verification
bun run --cwd vendor/onequery formatbun run --cwd vendor/onequery/packages/ui typecheckbun run --cwd vendor/onequery/packages/ui test src/data-sources/provider-icons.test.tsxbun run --cwd vendor/onequery/apps/landing typecheckbun run --cwd vendor/onequery/apps/landing test src/shared/icons/brands.test.tsxVideo / Screenshot (Optional)