Skip to content

fix(ui): use 1Password brand icon - #316

Merged
siisee11 merged 1 commit into
mainfrom
codex/use-1password-icon
Jul 16, 2026
Merged

fix(ui): use 1Password brand icon#316
siisee11 merged 1 commit into
mainfrom
codex/use-1password-icon

Conversation

@siisee11

Copy link
Copy Markdown
Contributor

One-Line Summary

Show the official 1Password brand mark instead of a generic key icon in provider icon surfaces.

User-Facing Changes

  • Updates the onepassword provider icon in the app UI and landing brand icon registry to use the Simple Icons 1Password mark.

Why This Changed

The previous icon was a generic key outline, which made 1Password less recognizable beside providers that already use brand-specific marks.

How It Changed

  • Imports si1password from simple-icons.
  • Maps onepassword through the existing Simple Icons wrapper in packages/ui and apps/landing.
  • Removes the now-unused custom 1Password SVG and Tabler key fallback.

Bug Fixes

  • Under provider lists or landing icon displays, onepassword no longer appears as a generic key icon.

Verification

  • bun run --cwd vendor/onequery format
  • bun run --cwd vendor/onequery/packages/ui typecheck
  • bun run --cwd vendor/onequery/packages/ui test src/data-sources/provider-icons.test.tsx
  • bun run --cwd vendor/onequery/apps/landing typecheck
  • bun run --cwd vendor/onequery/apps/landing test src/shared/icons/brands.test.tsx

Video / Screenshot (Optional)

  • N/A

@siisee11
siisee11 enabled auto-merge (squash) July 16, 2026 05:22
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
onequery-landing ccfd507 Commit Preview URL

Branch Preview URL
Jul 16 2026, 05:23 AM

@siisee11
siisee11 merged commit 3f28d54 into main Jul 16, 2026
9 checks passed
@siisee11
siisee11 deleted the codex/use-1password-icon branch July 16, 2026 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant