Skip to content

fix(types): normalize Buffer API boundaries - #312

Merged
siisee11 merged 1 commit into
mainfrom
codex/velen-buffer-type-compat
Jul 15, 2026
Merged

fix(types): normalize Buffer API boundaries#312
siisee11 merged 1 commit into
mainfrom
codex/velen-buffer-type-compat

Conversation

@siisee11

Copy link
Copy Markdown
Contributor

Summary

  • copy Node Buffer values into ArrayBuffer-backed Uint8Array values before passing them to WebAssembly, Blob, Protobuf, and crypto APIs
  • keep audit payload serialization and corruption tests byte-for-byte equivalent without relying on incompatible Buffer overloads
  • restore typecheck compatibility when OneQuery is consumed as the Velen workspace submodule

Validation

  • mise exec -- bunx turbo typecheck --json --filter=@onequery/db --filter=@onequery/server --filter=@onequery/cli-server
  • mise exec -- bunx oxlint <changed-files> --type-aware --type-check --format json
  • mise exec -- bun run format
  • mise exec -- bunx turbo test --json --filter=@onequery/db --filter=@onequery/server --filter=@onequery/cli-server — 461 tests passed

Context

Velen local CI typechecks affected OneQuery packages from the parent workspace. The previous direct Buffer API calls failed under that combined Node and Bun type environment even though their runtime bytes were valid.

@siisee11
siisee11 enabled auto-merge (squash) July 15, 2026 02:29
@siisee11
siisee11 merged commit 65dc867 into main Jul 15, 2026
8 of 9 checks passed
@siisee11
siisee11 deleted the codex/velen-buffer-type-compat branch July 15, 2026 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant