Update to IDF 5.5.4 - #5769
Conversation
WalkthroughThe PR updates ESP32 IDF V5 platform versions and settings, raises the PlatformIO requirement, removes ESP32-C5 NTP overrides, and adjusts SHA1, ChangesESP32 IDF V5 compatibility
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
DedeHai
left a comment
There was a problem hiding this comment.
tested on ESP32 classic, works.
|
@softhack007 I got my C5. It works with latest tasmota and also enabling NTP gives me no crashes. |
|
Merge once you are happy please @softhack007 |
@netmindz I'll take a look on Sunday 👍 Edit: on Monday |
align with tasmota platform version
This seems to be a known "hickup" on -C5 with PSRAM espressif/arduino-esp32#12587 |
I can also cross-check this on my board. The -C5 crash was always kind of mysterious - maybe it was a consequence of another bug we already fixed in |
crash on NTP does not occur any more, C5 builds successfully with tasmota core.
@DedeHai both observations confirmed on my board (C5 devkit N8R4, chip revision v1.0, with PSRAM)
|
espressif uses a new format in ESP.getChipRevision() now: revMajor*100 + revMinor
|
@coderabbitai full review |
✅ Action performedFull review finished. |
softhack007
left a comment
There was a problem hiding this comment.
Looks good for me now.
@DedeHai can you give it a quick spin on your boards? If nothing unexpected comes up, we should be good to merge.
|
I am afk until next monday |
Not tested with hardware yet, but this gets the build to pass
Summary by CodeRabbit