feat: new icon suggestion#818
Open
hellasol wants to merge 2 commits into
Open
Conversation
lsmith77
reviewed
May 8, 2023
lsmith77
left a comment
lsmith77
left a comment
Contributor
There was a problem hiding this comment.
yeah I think that is a legitimate compromise.
however now the icon scrolls with the main scrollbar:
lsmith77
force-pushed
the
dev
branch
3 times, most recently
from
February 9, 2024 15:45
63cfe21 to
0db4679
Compare
lsmith77
force-pushed
the
dev
branch
2 times, most recently
from
February 17, 2024 11:06
3acd3dd to
d3428e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lsmith77 I dont think there is an easy way of always keeping the icon visible at the bottom (if we do, I will have to make many different solutions). At the top however works in most situations ( + this way, we also stop crashing with grammarly/LT etc.). can you let me know what you think?