Conversation
Contributor
|
Hi @henih! May I see your implementation of keyboard shortcuts in service worker as well? I can only see the manifest part right now if I'm correct. |
Contributor
Author
|
Hi @imilka , I haven't even got that far because I got already stuck on the sample code disappearing. |
Contributor
|
@henih Am I right that you are trying to edit background.bundle.js? Also, could you tell me what is that you are trying to achieve? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves: #927
Blocking: Supposedly the function for the custom keyboard shortcut should be implemented in the service_worker file, but after the script runs it disappears from the file.
Hi @imilka , do you have any ideas why this might be happening?
I tried following the implementation instructions from here for MV3.
Related articles:
https://blog.shahednasser.com/how-to-add-keyboard-shortcuts-in-a-chrome-extension/#adding-a-standard-command
https://issues.chromium.org/issues/40756021
https://developer.chrome.com/docs/extensions/reference/api/commands