Skip to content

feat: show next alert time - #132

Merged
williscool merged 19 commits into
masterfrom
feat/show-next-alert-time
Jan 1, 2026
Merged

feat: show next alert time#132
williscool merged 19 commits into
masterfrom
feat/show-next-alert-time

Conversation

@williscool

@williscool williscool commented Dec 25, 2025

Copy link
Copy Markdown
Owner

Calendar

image

Muted

image

App Alert

image

Muted

image

refs #89 and #87

fixes #90 fixes #14

  • feat: show next alert time
  • test: wip
  • fix: display string and roboelectric tests
  • fix: feature works plus test activity

Note

Introduces a user-configurable next-alert indicator in notifications and hardens CI to prevent accidental dev-page exposure.

  • Adds next-alert indicator formatting in EventFormatter (📅 calendar reminders, 🔔 app alerts, optional 🔇 prefix) with calculateNextNotification logic and formatNextNotificationIndicator[ForCollapsed]
  • Shows indicator in single-event secondary text and collapsed notification titles via EventNotificationManager
  • New settings displayNextGCalReminder (default true) and displayNextAppAlert (default false) with UI in notification_preferences_x.xml and backing in Settings
  • Adds EventRecord.getNextAlertTimeAfter helper for computing future reminders
  • Updates TestActivity and activity_test.xml with buttons to demo individual/collapsed/muted/app-alert cases
  • Updates strings and docs; removes legacy reminder_at text; adds next_*_indicator and muted_prefix
  • CI: new safety_checks job and release step running scripts/check_dev_page_hidden.sh; build gated on it
  • Build/dev: build.gradle reads DEV_PAGE_ENABLED from local.properties; MainActivity toggles test page visibility using BuildConfig.DEV_PAGE_ENABLED
  • Tests: extensive unit/instrumentation coverage for new settings, formatter logic, and EventRecord extension

Written by Cursor Bugbot for commit 80d2b85. This will update automatically on new commits. Configure here.

@williscool williscool changed the title feat/show next alert time feat: show next alert time Dec 25, 2025
Comment thread android/app/src/main/java/com/github/quarck/calnotify/Settings.kt Outdated
Comment thread android/app/src/main/java/com/github/quarck/calnotify/ui/TestActivity.kt Outdated
@github-actions

Copy link
Copy Markdown

Build artifacts for PR #132 (commit 9a9fcb8) are available:

You can download these artifacts from the "Artifacts" section of the workflow run.

@github-actions

github-actions Bot commented Dec 25, 2025

Copy link
Copy Markdown

Code Coverage Report

Overall Project 32.21% -0.89% 🍏
Files changed 38.35%

Module Coverage
app 43.58% -0.43%
x8664Debug 21.08% -1.34%
Files
Module File Coverage
app Settings.kt 69.99% -0.93%
EventFormatter.kt 68.04% -14.59%
EventRecord.kt 48.79% 🍏
MainActivity.kt 45.79% -0.17% 🍏
EventNotificationManager.kt 43.24% -2.17%
x8664Debug EventFormatter.kt 74.54% -5.44% 🍏
EventRecord.kt 53.8% 🍏
MainActivity.kt 44.96% -0.17% 🍏
Settings.kt 22.37% -0.93%
EventNotificationManager.kt 5.73% -2.17%
TestActivity.kt 0% -56.64%

@github-actions

Copy link
Copy Markdown

📊 Code Coverage Summary

Coverage Type Coverage
Overall 33.89
Changed Files 50.37

View detailed coverage report

@williscool
williscool force-pushed the feat/show-next-alert-time branch from 100762a to 4c1a0cf Compare January 1, 2026 07:46
Comment thread android/app/src/main/java/com/github/quarck/calnotify/ui/TestActivity.kt Outdated
@github-actions

github-actions Bot commented Jan 1, 2026

Copy link
Copy Markdown

📊 Code Coverage Summary

Coverage Type Coverage
Overall null
Changed Files 100

View detailed coverage report

@github-actions

github-actions Bot commented Jan 1, 2026

Copy link
Copy Markdown

Build artifacts for PR #132 (commit 9b814b6) are available:

You can download these artifacts from the "Artifacts" section of the workflow run.

@github-actions

github-actions Bot commented Jan 1, 2026

Copy link
Copy Markdown

📊 Code Coverage Summary

Coverage Type Coverage
Overall 32.23
Changed Files 36.84

View detailed coverage report

@github-actions

github-actions Bot commented Jan 1, 2026

Copy link
Copy Markdown

📊 Code Coverage Summary

Coverage Type Coverage
Overall 21.12
Changed Files 27.46

View detailed coverage report

@github-actions

github-actions Bot commented Jan 1, 2026

Copy link
Copy Markdown

Build artifacts for PR #132 (commit fa2adf2) are available:

You can download these artifacts from the "Artifacts" section of the workflow run.

@github-actions

github-actions Bot commented Jan 1, 2026

Copy link
Copy Markdown

📊 Code Coverage Summary

Coverage Type Coverage
Overall 32.31
Changed Files 38.73

View detailed coverage report

@github-actions

github-actions Bot commented Jan 1, 2026

Copy link
Copy Markdown

Build artifacts for PR #132 (commit 2215b7b) are available:

You can download these artifacts from the "Artifacts" section of the workflow run.

bobrippling and others added 13 commits January 1, 2026 16:31
- Add displayNextGCalReminder (default ON) and displayNextAppAlert (default OFF) settings
- Show 📅 for calendar reminders, 🔔 for app alerts, 🔇 prefix for muted
- Collapsed notifications show soonest next alert in title
- GCal wins ties when both are same time
- Add TestActivity buttons for individual, collapsed, and muted scenarios
- Add Robolectric tests for calculation logic
doing emoji X

instead of emoji in X makes it more clear this is static showing the next
from the original display of the notfication. not an active countdown
@williscool
williscool force-pushed the feat/show-next-alert-time branch from c2e855f to 80d2b85 Compare January 1, 2026 21:31
@williscool
williscool enabled auto-merge (squash) January 1, 2026 21:32
@github-actions

github-actions Bot commented Jan 1, 2026

Copy link
Copy Markdown

📊 Code Coverage Summary

Coverage Type Coverage
Overall null
Changed Files 100

View detailed coverage report

@github-actions

github-actions Bot commented Jan 1, 2026

Copy link
Copy Markdown

📊 Code Coverage Summary

Coverage Type Coverage
Overall 21.08
Changed Files 27.01

View detailed coverage report

@github-actions

github-actions Bot commented Jan 1, 2026

Copy link
Copy Markdown

Build artifacts for PR #132 (commit a872128) are available:

You can download these artifacts from the "Artifacts" section of the workflow run.

@github-actions

github-actions Bot commented Jan 1, 2026

Copy link
Copy Markdown

📊 Code Coverage Summary

Coverage Type Coverage
Overall 32.21
Changed Files 38.48

View detailed coverage report

@williscool
williscool disabled auto-merge January 1, 2026 22:10
@williscool
williscool merged commit 1132b58 into master Jan 1, 2026
16 checks passed
@williscool williscool mentioned this pull request Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need a way to make sure the test activity is disabled on a real device

2 participants