Dockerfile: Fix cdrdao version detection & discid issues with trixie update#689
Open
sjrct wants to merge 3 commits into
Open
Dockerfile: Fix cdrdao version detection & discid issues with trixie update#689sjrct wants to merge 3 commits into
sjrct wants to merge 3 commits into
Conversation
Newer crdo gives "1.2.5 - (C) Andreas Mueller <andreas@daneb.de>" when we only want the version number, so change the regex to break at the first space. Signed-off-by: Chris Harding <sjrct@users.noreply.github.com>
I don't believe there is a debian package for this, at least not that I could see. Signed-off-by: Chris Harding <sjrct@users.noreply.github.com>
This was referenced Jun 14, 2026
Using pip install . rather than running setup.py directly correctly sets up the whipper version. However, it was then failing when installing PyGObject/pycairo. But nothing appears to use that, so I removed it. Signed-off-by: Chris Harding <sjrct@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I tested #668, I ran into the issues reported there and an issue with the python
discidpackage not being installed.This fixes those issues as follows:
discidpip package. I don't believe there is a debian package, at least not that I could find.pip install .rather thansetup.pydirectly to fix the 0.0.0 version issuePyGObjectthat was causing that to failI was able to rip a CD with this branch