add lending to event creating/editing by ShaileshS1702 · Pull Request #5863 · webkom/lego-webapp

ShaileshS1702 · 2026-02-10T18:20:46Z

Description

Add the possibility of lending an object directly from the event edit form

Result

If you've made visual changes, please check the boxes below and include images showing the changes. Descriptions are appreciated.

Changes look good on both light and dark theme.
Changes look good with different viewports (mobile, tablet, etc.).
Changes look good with slower Internet connections.

Caution

Make sure your images do not contain any real user information.

Description	Before	After
Dark mode	...
Dark mode with lending objects chosen	...	`</td> </tr>`

Testing

I have thoroughly tested my changes.

Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.

Resolves #5862

ch0rizo

Really cool feature!

ch0rizo

M

jonasdeluna

This is very cool! Could we have some relation between the event and requests, so that we can see/filter on the event page or in the ending page based on events? The event could for example store its own lending requests?
Could be a separate more extensive feature though

…tings

…e failures

…ty fetch, clear stale availability, add tests

ch0rizo

I think this a nice and useful feature!! There are some bugs and fixes I would take a closer look.

ch0rizo · 2026-05-18T13:11:28Z

+          for (let i = 0; i < values.lendingObjects.length; i++) {
+            const lendingRequestData: CreateLendingRequest = {
+              lendableObject: values.lendingObjects[i].value,
+              comment: values.lendingDescription[i] || '',


Suggested change

comment: values.lendingDescription[i] || '',

comment: values.lendingDescription?[i] || '',

Crash when an object is selected but no comment typed. Here you fix it with a default empty string. However, lendingDescription is not in the initialValues. If the user selects a lending object, but never types into any comment field, values.lendingDescription is undefined -> underfined[i] throws on submit. Basically since values.lendingDescription is an array it will fail before hitting the default ''

ch0rizo · 2026-05-18T13:13:41Z

+          void dispatch(setSaveForUse(key, token, true));
+        }
+
+        // Create lending request if lendingObjects exist and we're creating a new event


I am worried that this will create a lending request on editing the event aswell. Because there are no difference between edit and create form. There should gated with isEditPage.

ch0rizo · 2026-05-18T13:20:17Z

+export const fetchAvailableLendableObjectIdsByDate = (
+  start_date: string | Dateish,
+  end_date: string | Dateish,
+) =>
+  callAPI<EntityId[]>({
+    types: LendableObjects.FETCH_AVAILABLE,
+    endpoint: '/lending/objects/available/',
+    query: { start_date, end_date },
+    meta: {
+      errorMessage: 'Henting av tilgjengelige utlånsobjekter feilet',
+    },
+    propagateError: true,
+  });


Availability fetch keys off startTime/endTime which is never change in the form (LendingSection.tsx). The form's date field is name="date" (a range) -> values.date[0]/values.date[1]. There is no date-driven startTime/endTime on form values. This means:

On create: startTime/endtime are undefined -> always hits the clear branch, availability is never fetched.

On edit: they hold the stale initial values -> fetched once with the original dates, never updates when the user picks a new range.

However onSubmit correctly uses values.date[0]/values.date[1] for the request - so the two halves of the feature disagree. A possible solution is to switch the availability effect to values.date?.[0] / values.date?.[1]

ch0rizo · 2026-05-18T13:26:25Z

+        // eslint-disable-next-line no-console
+        console.error('fetchAllLendableObjects failed', err);


I would not leave this in prod. If errors is to be announced it should be through user friendly toasts

ch0rizo · 2026-05-18T13:26:36Z

+          // eslint-disable-next-line no-console
+          console.error('fetchAvailableLendableObjectIdsByDate failed', err);


Here as well :)

ch0rizo · 2026-05-18T13:38:17Z

+    // Attach a requestId to meta for request identity (used to ignore stale responses)
+    const requestId = `${Date.now()}-${Math.random().toString(36).slice(2, 9)}`;


This is a global change. callAPI.ts is a the foundation of every redux API action in the app. This will add requestId to every action's meta.

Maybe reconsider making a global change for a local need. A proposed solution would be to solve the stale-response handling locally in LendingSection, without touching callAPI at all. The thunk from dispatch(fetchAvailable…) already returns a promise - you can await it and compare against the latest dispatched date range (or keep the "latest request" marker in a useRef (probably not a ideal🤷‍♂️)).

ch0rizo · 2026-05-18T13:40:19Z

+  FETCH_AVAILABLE: generateStatuses('LendableObject.FETCH_AVAILABLE'),
  FETCH_AVAILABILITY: generateStatuses('LendableObject.FETCH_AVAILABILITY'),


What is the difference? Should there be a single source of truth, if they have the same purpose

Its a bit confusing with the naming convention. Seems one is for bulk availability and the other one for a specific one

ch0rizo · 2026-05-18T13:41:50Z

+          state.lastAvailabilityRequestId = action.meta?.requestId ?? null;
+        },
+      );
+      addCase(
+        LendableObjects.FETCH_AVAILABLE.SUCCESS,
+        (state, action: AnyAction) => {
+          // Only apply success payload if it matches the latest request id
+          const requestId = action.meta?.requestId ?? null;
+          if (requestId && state.lastAvailabilityRequestId !== requestId) {
+            // stale response — ignore
+            return;
+          }
+          state.availabilityFetchFailed = false;
+          state.availableIds = action.payload;
+        },
+      );
+      addCase(
+        LendableObjects.FETCH_AVAILABLE.FAILURE,
+        (state, action: AnyAction) => {
+          const requestId = action.meta?.requestId ?? null;


Consider rewriting this if you didn't change callAPI.ts

ch0rizo · 2026-05-18T13:43:20Z

Just curious what is this for?

add lending to event creating/editing

8b90cd2

ShaileshS1702 self-assigned this Feb 10, 2026

github-actions Bot added the review-needed Pull requests that need review label Feb 10, 2026

ShaileshS1702 force-pushed the 3884-add-lending-to-events branch from b9ce526 to 82306b4 Compare February 10, 2026 21:14

ch0rizo approved these changes Feb 26, 2026

View reviewed changes

ch0rizo reviewed Feb 26, 2026

View reviewed changes

Comment thread lego-webapp/pages/events/src/EventEditor/index.tsx Outdated

add lending to event creating/editing

22ad34b

ShaileshS1702 force-pushed the 3884-add-lending-to-events branch from 82306b4 to 22ad34b Compare February 26, 2026 11:44

ShaileshS1702 and others added 2 commits February 26, 2026 13:14

fix date is not correct on event creation

95249ff

Merge branch 'master' into 3884-add-lending-to-events

db5dcbf

ch0rizo reviewed Feb 26, 2026

View reviewed changes

Comment thread lego-webapp/pages/events/src/EventEditor/index.tsx Outdated

jonasdeluna approved these changes Mar 2, 2026

View reviewed changes

ShaileshS1702 added 2 commits April 7, 2026 21:42

feature: shows availability of objects when lending through event set…

de7e9cb

…tings

Merge branch 'master' into 3884-add-lending-to-events

fdfd487

ShaileshS1702 requested a review from ch0rizo April 13, 2026 16:16

Merge branch 'master' into 3884-add-lending-to-events

f554c29

ShaileshS1702 force-pushed the 3884-add-lending-to-events branch from 8513cb5 to f554c29 Compare April 13, 2026 18:17

ShaileshS1702 and others added 3 commits April 22, 2026 18:31

fix prettiers problems

cf0c025

Merge branch 'master' into 3884-add-lending-to-events

49dd434

remove redundant logs

b7ab5ef

ShaileshS1702 force-pushed the 3884-add-lending-to-events branch from bce2305 to b7ab5ef Compare April 22, 2026 17:09

ShaileshS1702 added 4 commits May 16, 2026 20:23

show message when lendable object request fail

aaa6b51

Merge branch 'master' into 3884-add-lending-to-events

4892002

fix(events): debounce availability fetch, clear stale results, surfac…

b6451b8

…e failures

fix(events): ignore stale availability responses, debounce availabili…

4d8464d

…ty fetch, clear stale availability, add tests

ShaileshS1702 force-pushed the 3884-add-lending-to-events branch from b20825b to aee42ac Compare May 18, 2026 10:18

Merge branch 'master' into 3884-add-lending-to-events

5b793bc

ShaileshS1702 force-pushed the 3884-add-lending-to-events branch from aee42ac to 5b793bc Compare May 18, 2026 10:29

ch0rizo requested changes May 18, 2026

View reviewed changes

	comment: values.lendingDescription[i] \|\| '',
	comment: values.lendingDescription?[i] \|\| '',

		// eslint-disable-next-line no-console
		console.error('fetchAllLendableObjects failed', err);

		// eslint-disable-next-line no-console
		console.error('fetchAvailableLendableObjectIdsByDate failed', err);

		// Attach a requestId to meta for request identity (used to ignore stale responses)
		const requestId = `${Date.now()}-${Math.random().toString(36).slice(2, 9)}`;

		FETCH_AVAILABLE: generateStatuses('LendableObject.FETCH_AVAILABLE'),
		FETCH_AVAILABILITY: generateStatuses('LendableObject.FETCH_AVAILABILITY'),

Uh oh!

Conversation

ShaileshS1702 commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Result

Testing

Uh oh!

ch0rizo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ch0rizo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jonasdeluna left a comment

Choose a reason for hiding this comment

Uh oh!

ch0rizo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ShaileshS1702 commented Feb 10, 2026 •

edited

Loading