Prevent admin functionality on own lendingRequest - #5795
Open
itsisak wants to merge 1 commit into
Open
Conversation
itsisak
added
small-fix
2 tasks
magnusbrecke
reviewed
Nov 9, 2025
magnusbrecke
left a comment
magnusbrecke
left a comment
Contributor
There was a problem hiding this comment.
Design question: Should it have some background-color of some red/orange color to indicate "you are not allowed"?
Contributor
Author
Do you mean to color the text? Or like use a red info box, sort of like on events if you have unanswered surveys? Imo, i think this looks the most clean and less "intrusive", I even considered just removing the whole admin section in this case, but figured people might be a bit confused as to why it might suddenly dissapear |
ch0rizo
approved these changes
Nov 11, 2025
ch0rizo
left a comment
ch0rizo
left a comment
Contributor
There was a problem hiding this comment.
Nice you fixed the text also😝
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A user should not have any admin functionality on their own requests. This should be fixed in backend too as currently only "approve" is not allowed on own requests.
Also just centering content of statuspill.
Result
If you've made visual changes, please check the boxes below and include images showing the changes. Descriptions are appreciated.
Caution
Make sure your images do not contain any real user information.