Editorial: queue a task in ServiceWorkerContainer.getRegistration - #1833
Merged
Conversation
…getRegistration The step running in parallel resolved/rejected the promise directly, which violates the 'don't touch JS objects from parallel' rule. Wrap it in a Queue a task on the responsible event loop. Refs: w3c#1740
yoshisatoyanagisawa
approved these changes
Jul 17, 2026
yoshisatoyanagisawa
left a comment
yoshisatoyanagisawa
left a comment
Collaborator
There was a problem hiding this comment.
lgtm w/ comment.
Per @yoshisatoyanagisawa: Match Service Worker Registration should stay in the parallel block so it runs in parallel; only the promise-resolution steps need to be inside the Queue a task.
monica-ch
marked this pull request as ready for review
July 17, 2026 16:12
github-actions Bot
added a commit
that referenced
this pull request
Jul 17, 2026
) SHA: 0467916 Reason: push, by monica-ch Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot
added a commit
to asleekgeek/ServiceWorker
that referenced
this pull request
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to navigator-service-worker-getRegistration.
The step running in parallel resolved/rejected the promise directly, which violates the "don't touch JS objects from parallel" rule. Wrap it in a
Queue a taskon the responsible event loop.This is part 1/6 of #1740. Split out from #1755 for focused review.
Preview | Diff