Add CredentialIssuer service labels to impersonator Services - #3235
Open
0hlov3 wants to merge 1 commit into
Open
Add CredentialIssuer service labels to impersonator Services#32350hlov3 wants to merge 1 commit into
0hlov3 wants to merge 1 commit into
Conversation
Wire spec.impersonationProxy.service.labels into generated LoadBalancer and ClusterIP Service metadata, update generated API artifacts, and cover label reconciliation in controller tests. Signed-off-by: 0hlov3 <dev@schoenwald.aero>
✅ Deploy Preview for pinniped-dev canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for configuring custom labels on Concierge impersonation proxy Services through
CredentialIssuer.spec.impersonationProxy.service.labels.The configured labels are merged with Pinniped's existing controller-managed labels and applied to both generated Service types:
The existing Service reconciliation logic tracks the configured labels as managed labels. This allows CredentialIssuer-provided values to take precedence for managed keys while preserving unrelated labels added by other controllers or users.
This change also:
LoadBalancerandClusterIPServicesFixes #3233
Release note: