refactor: Enhance token exchange logic for RFC8693 compliance - #3227
Open
yuito-it wants to merge 1 commit into
Open
refactor: Enhance token exchange logic for RFC8693 compliance#3227yuito-it wants to merge 1 commit into
yuito-it wants to merge 1 commit into
Conversation
Signed-off-by: Yuito Akatsuki (Tani Yutaka) <yuito@yuito-it.jp>
✅ Deploy Preview for pinniped-dev canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the
needRFC8693TokenExchangefunction in the Pinniped CLI to handle bothstringandslicetypes ([]string/[]interface{}) for theaudclaim in ID tokens when checking againstrequestedAudience.Background / Details
audclaim as an array/slice (e.g.,["client-id"]), comparing it directly against a stringrequestedAudiencecaused type mismatches or unexpected condition evaluations.requestedAudienceis present in theaudclaim regardless of whetheraudis formatted as a single string or a slice of strings/interfaces.Fixes
none
Release note