Skip to content

fix: Always show chart tab scroll buttons when needed - #2399

Merged
bprusinowski merged 2 commits into
mainfrom
feat/always-show-scroll-buttons-when-needed
Jul 23, 2025
Merged

fix: Always show chart tab scroll buttons when needed#2399
bprusinowski merged 2 commits into
mainfrom
feat/always-show-scroll-buttons-when-needed

Conversation

@bprusinowski

@bprusinowski bprusinowski commented Jul 23, 2025

Copy link
Copy Markdown
Member

Closes #1776

This PR makes sure we always show scroll arrows when needed to avoid empty spaces.

How to test

  1. Go to this link.
  2. ✅ See that the left arrow is visible without having to scroll.

  • I added a CHANGELOG entry
  • I made a self-review of my own code

@vercel

vercel Bot commented Jul 23, 2025

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2025 9:59am

@bprusinowski

Copy link
Copy Markdown
Member Author

@sosiology let me know if this solution works for you :)

@sosiology

sosiology commented Jul 23, 2025

Copy link
Copy Markdown
Contributor

@bprusinowski this LGTM thanks! I think we should create a new issue for the 2nd point (the long tab titles). This is not something i think we need to solve now, but maybe in future across the whole application (text blocks, titles, descriptions), seeing as we now also introduced a character limit for the annotations.
example chart: https://visualization-tool-git-feat-always-show-scroll-butt-ad5f82-ixt1.vercel.app/en/v/cOblylIPvXmw?dataSource=Prod

This would also solve issues like this in the user profile:
image
(this is a chart with a really long title: https://test.visualize.admin.ch/en/v/cnfOO8buWlVY?dataSource=Prod

@sosiology

Copy link
Copy Markdown
Contributor

This would also solve issues like this in the user profile:
image
(this is a chart with a really long title: https://test.visualize.admin.ch/en/v/cnfOO8buWlVY?dataSource=Prod

But i now see you already solved this issue here: #2400 🏃

@bprusinowski

bprusinowski commented Jul 23, 2025

Copy link
Copy Markdown
Member Author

Thanks @sosiology! Yes, I agree – this would be quite easy to enforce once we merge annotations PR 👍

…into feat/always-show-scroll-buttons-when-needed
@bprusinowski
bprusinowski merged commit 3fd9958 into main Jul 23, 2025
6 of 7 checks passed
@bprusinowski
bprusinowski deleted the feat/always-show-scroll-buttons-when-needed branch July 23, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✓ Tab Label Improvements

2 participants