Fix duplicate Odin 3 headphones UCM section#141
Open
bernhardberger wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SectionDevice."Headphones"block from the Odin 3 UCM profilehw:${CardId},1; the removed copy incorrectly reused speaker PCMhw:${CardId},0Context
The duplicate was inherited from AYN's SM8750 UCM contribution. Both blocks declare the same UCM device identifier, but point at different PCMs.
This malformed profile may contribute to #120. I have Odin 3 hardware, but it is not currently running Armada, so I could not verify jack detection or routing with this change. This PR therefore references rather than closes that issue; insertion/removal, automatic speaker mute, and headphone playback still need validation on-device under Armada.
Testing
bash tests/alsa-ucm-duplicates-test.shtests/*-test.shloopshfmt --diff tests/alsa-ucm-duplicates-test.shgit diff --checkjustandshellcheckwere not available in the local environment.