style: cargo fmt --all across the workspace#120
Conversation
|
Please don't... The automatic formatter is terribly ugly for this kind of crate |
Mechanical, whitespace-only reformat to satisfy the repo's rustfmt.toml. No semantic changes. Regenerated on current master; unblocks a hard 'cargo fmt --all -- --check' CI gate.
a4d67d1 to
861de65
Compare
|
@AdrianEddy could you a tad more be specific?
It means I that wenn I look at Rust code from other people how they format is never an obstacle in reading the code. It was many times in the 25 years I had to look at other people's C/C++ code so I'm rather grateful for this. If you don't like any of the additional choices in But this PR will be merged one way or another, sooner or later for the reason given above. |
|
I have nothing against rustfmt in regular rust crates, but this is a macro-heavy code on top of the Adobe API from the 80's.
This is not something rustfmt.toml can fix, and adding #[rustfmt::skip] to every function is not reasonable. I simply don't see any advantage of running rustfmt on this crate. To me it's a change to the worse for no benefit whatsoever. But I guess now that AI is maintaining all the code anyway it doesn't matter and I can't stop you anyway. |








Mechanical, whitespace-only
cargo fmt --allto satisfy the repo's ownrustfmt.toml. The tree was previously not fmt-clean (the config enables options the code was never formatted against), socargo fmt --all -- --checkfailed repo-wide. After this, it exits 0.rustfmt.toml).fmt --checkstep (added in Fix reachable-panic unwraps (non-breaking) + add justfile/CI gates #114) can be flipped to enforcing.Merge order
Because this touches ~124 files it will conflict with every other open PR. Merge this last, then a fresh
cargo fmt --allregenerates it in seconds if needed -- do not hand-resolve conflicts. Refs the blueprint vet.